Allowlist known blocking methods from BlockHound #2897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 7, 2021 13:24
There are two known occurrences where the SDK may currently block from within a Netty EventLoop: 1. aws#2145 2. aws#2360 Allowing BlockHound to forbid these operations may fail existing integration and stability tests. While we have outstanding issues to fix these items, until they are resolved, we need to allow our existing integration tests to continue to pass. We should explicitly allow-list these methods so that they do not interfere with existing tests and so that we maintain visibility on future regression detection.
Bennett-Lynch
changed the title
|
SonarCloud Quality Gate failed. |
Bennett-Lynch
changed the title
zoewangg
reviewed
Dec 8, 2021
...ls/src/main/resources/META-INF/services/reactor.blockhound.integration.BlockHoundIntegration
Show resolved
Hide resolved
zoewangg
approved these changes
Dec 8, 2021
joviegas
approved these changes
Dec 8, 2021
aws-sdk-java-automation
pushed a commit
that referenced
this pull request
Feb 9, 2024
Bumping minor version to 2.24.0 due to core refactoring and moving aw…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two known occurrences where the SDK may currently block from within a Netty EventLoop:
Allowing BlockHound to forbid these operations may fail existing integration and stability tests. While we have outstanding issues to fix these items, until they are resolved, we need to allow our existing integration tests to continue to pass. We should explicitly allow-list these methods so that they do not interfere with existing tests and so that we maintain visibility on future regression detection.
License