Enable & fix inspection: equals() called on enum value
#2819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reports `equals()` calls on enum constants.
Such calls can be replaced by an identity comparison (`==`) because two
enum constants are equal only when they have the same identity.
A quick-fix is available to change the call to a comparison.
Example:
```
boolean foo(MyEnum value) {
return value.equals(MyEnum.FOO);
}
```
After the quick-fix is applied:
```
boolean foo(MyEnum value) {
return value == MyEnum.FOO;
}
```
cenedhryn
approved these changes
Nov 3, 2021
|
Kudos, SonarCloud Quality Gate passed! |
aws-sdk-java-automation
pushed a commit
that referenced
this pull request
Nov 28, 2023
…d90c1dfcf Pull request: release <- staging/d918cad1-d118-454f-b024-acdd90c1dfcf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reports
equals()calls on enum constants.Such calls can be replaced by an identity comparison (
==) because twoenum constants are equal only when they have the same identity.
A quick-fix is available to change the call to a comparison.
Example:
After the quick-fix is applied:
License