Fix SDK behavior when request content-length does not match the data length returned by the publisher. #2788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millems
force-pushed
the
millem/async-content-length-fixes
branch
from
1b8de1b to
b8eec86
Compare
millems
force-pushed
the
millem/async-content-length-fixes
branch
from
b8eec86 to
8b7d89d
Compare
...n/java/software/amazon/awssdk/services/s3/checksums/ChecksumCalculatingAsyncRequestBody.java
Show resolved
Hide resolved
dagnir
reviewed
Oct 22, 2021
...n/java/software/amazon/awssdk/services/s3/checksums/ChecksumCalculatingAsyncRequestBody.java
Outdated
Show resolved
Hide resolved
cenedhryn
reviewed
Oct 22, 2021
...n/java/software/amazon/awssdk/services/s3/checksums/ChecksumCalculatingAsyncRequestBody.java
Outdated
Show resolved
Hide resolved
...lient/src/main/java/software/amazon/awssdk/http/nio/netty/internal/NettyRequestExecutor.java
Show resolved
Hide resolved
millems
force-pushed
the
millem/async-content-length-fixes
branch
from
8b7d89d to
dc773ec
Compare
cenedhryn
approved these changes
Oct 25, 2021
...n/java/software/amazon/awssdk/services/s3/checksums/ChecksumCalculatingAsyncRequestBody.java
Show resolved
Hide resolved
utils/src/main/java/software/amazon/awssdk/utils/BinaryUtils.java
Outdated
Show resolved
Hide resolved
Bennett-Lynch
approved these changes
Oct 25, 2021
…length returned by the publisher. This fixes two potential bugs: 1. A source of "checksum mismatch" exceptions (#953) when the published data length exceeds the content-length. 2. A source of "hung futures" (#2576?) when the published data is shorter than the content-length. This may not be the definitive fix for those two issues.
millems
force-pushed
the
millem/async-content-length-fixes
branch
from
dc773ec to
6246e74
Compare
|
Kudos, SonarCloud Quality Gate passed! |
aws-sdk-java-automation
added a commit
that referenced
this pull request
Nov 16, 2023
…8b68d6c70 Pull request: release <- staging/0017c096-a560-41bd-97eb-4a78b68d6c70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two bugs:
This may not be the definitive fix for those two issues.