Use System Property Proxy Settings for Netty and Amazon CRT HTTP Clients

[erin889]

Motivation and Context

• We would like to let Netty and Amazon CRT http clients to read in proxy configurations from system properties.
• Apache proxy configuration has set up this, so we should have feature parity with other SDKs.The older aws-sdk-java has this feature parity that they are aware of system proxy settings.
• This resolves the issue Proxy configurations for different SDK http clients doesn't have feature parity.  #2321
• This also resolves Use http_proxy enviroment variable for ProxyConfiguration #1793 but requires another PR to support HTTPS settings since this only deals with HTTP.

Description

We modify the ProxyConfiguration so it resolves http.proxyHost, http.proxyPort, http.nonProxyHosts, http.proxyUser, http.proxyPassword from system property settings by default. If they are set explicitly like .builder().host(...), it will pick up the configuration specified, otherwise it will reads from system property.

Testing

see ProxyConfigurationTest files

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Checklist

• I have read the CONTRIBUTING document
• Local run of mvn install succeeds
• My code follows the code style of this project
• My change requires a change to the Javadoc documentation
• I have updated the Javadoc documentation accordingly
• I have read the README document
• I have added tests to cover my changes
• All new and existing tests passed
• A short description of the change has been added to the CHANGELOG
• My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

• I confirm that this pull request can be released under the Apache 2 license

[debora-ito]

Looks good to me, found a couple of typos.
I see you kept the implementation consistent with the Apache client ProxyConfiguration.

Will ask for an additional review from the team.

[Bennett-Lynch]

Hey @erin889, thanks for the PR! Apologies for the slow turnaround time.

Please see my feedback below. I will be quicker to respond to any future updates.

[erin889]

@Bennett-Lynch @debora-ito Thanks for the review! I have made some updates regarding the review, feel free to take a look.

[Bennett-Lynch]

I think we need to preserve this set-copy logic. Otherwise, if a user has a ProxyConfiguration and calls toBuilder(), any modifications on the builder's set will be reflected in the original, which should be immutable.

[erin889]

Good call, I have updated the constructor so NullPointerException won't be thrown.

[Bennett-Lynch]

Thanks for the PR, @erin889!

I forgot to mention this earlier, but please run scripts/new-change to add a change log entry and to have the change attributed to your name!

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

85.3% Coverage
13.0% Duplication

[debora-ito]

@all-contributors please add @erin889 for code.

[allcontributors]

@debora-ito

I've put up a pull request to add @erin889! 🎉