Skip to content

Updates xml error unmarshalling to look at all request id keys when p… #2764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 13, 2021

Conversation

cenedhryn
Copy link
Contributor

…opulating error information

Motivation and Context

When XML type error responses are received and the chain AwsS3ProtocolFactory -> AwsXmlErrorTransformer -> AwsXmlErrorUnmarshaller is activated, responses with empty body only populate the requestId value in the exception if the header contains the key x-amzn-RequestId and not the alternate x-amz-request-id

Description

Attempts to find any valid request id key in the response headers

Testing

Validated using the S3 head object API call

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@cenedhryn cenedhryn force-pushed the salande/fix-missing-requestid branch from 044c3cd to 090c10b Compare October 12, 2021 17:44
@cenedhryn cenedhryn requested a review from dagnir October 12, 2021 20:22
Copy link
Contributor

@dagnir dagnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Working on adding a test.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@cenedhryn cenedhryn merged commit 696e95d into master Oct 13, 2021
@cenedhryn cenedhryn deleted the salande/fix-missing-requestid branch October 13, 2021 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants