Update multi-region access point test #2758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… there are exsiting ones
Bennett-Lynch
approved these changes
Oct 8, 2021
| try { | ||
| s3Client.createBucket(b -> b.bucket(bucket)); | ||
| s3Client.waiter().waitUntilBucketExists(b -> b.bucket(bucket)); | ||
| } catch (BucketAlreadyOwnedByYouException | BucketAlreadyExistsException e) { |
There was a problem hiding this comment.
Would be nice if BucketAlreadyOwnedByYouException extended BucketAlreadyExistsException.
| private static final int RETRY_TIMES = 20; | ||
| private static final int RETRY_DELAY_IN_MS = 15 * 1000; | ||
| private static final int RETRY_TIMES = 10; | ||
| private static final int RETRY_DELAY_IN_SECONDS = 30; |
There was a problem hiding this comment.
Nit: Consider Duration instead.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update multi-region access point test to not create new resources because it can take a long time (> 10 mins) for the resource to transition to the READY status
Testing
Local testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense