Fix Sigv4a-signed requests to endpoints with non-standard ports. #2725
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signed host header must match the host header sent on the wire. HTTP clients append the port to the host header if the port is non-standard for the protocol being used. The current Sigv4a signer only adds the host, not the port, to the host header. This means that endpoints with non-standard ports for the protocol (e.g. an HTTPS service on port 8443) would get a signature validation failure, because the HTTP client will change the host header.
The Sigv4 signer handles this by adding the host header and port before calculating the signature. This PR adds that same logic to the Sigv4a signer.