Skip to content

Implement return values on DeleteItem #2719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 20, 2021
Merged

Implement return values on DeleteItem #2719

merged 3 commits into from
Sep 20, 2021

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Sep 16, 2021 •
edited by debora-ito
Loading

Motivation and Context

Requested feature request.

Description

This commit introduces DynamoDbTable#deleteItemWithResponse() that allows
customers to specify additional parameters on the request such as
ReturnConsumedCapacity to get additional information the service response.

Similar to #2710.

Relates to #1918, #2095.

Testing

  • Unit tests
  • Integration tests

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir dagnir force-pushed the deleteitem-returnvalues branch 2 times, most recently from 3600430 to 4300f22 Compare September 16, 2021 20:45
@dagnir
Copy link
Contributor Author

dagnir commented Sep 16, 2021

SonarCloud notes:

  • The duplication reported is unavoidable.
  • The bug is a false positive since we do call isPresent() first.

@dagnir dagnir force-pushed the deleteitem-returnvalues branch from 4300f22 to 28e1551 Compare September 16, 2021 21:46
@dagnir dagnir changed the title WIP return values on DeleteItem Implement return values on DeleteItem Sep 16, 2021
@dagnir dagnir marked this pull request as ready for review September 16, 2021 22:25
@dagnir dagnir force-pushed the deleteitem-returnvalues branch 2 times, most recently from 0dd3f0c to 9438055 Compare September 17, 2021 17:23
@dagnir
Implement return values for enhanced DeleteItem
0e14426 
This commit introduces DynamoDbTable#deleteItemWithResponse() that allows
customers to specify additional parameters on the request such as
ReturnConsumedCapacity to get additional information the service response.
@dagnir dagnir force-pushed the deleteitem-returnvalues branch from 1be6107 to 0e14426 Compare September 17, 2021 19:30
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

88.6% 88.6% Coverage
9.6% 9.6% Duplication

@dagnir dagnir merged commit f082af9 into aws:master Sep 20, 2021
@dagnir dagnir deleted the deleteitem-returnvalues branch September 20, 2021 16:20
aws-sdk-java-automation pushed a commit that referenced this pull request Oct 21, 2023
@dagnir
Merge pull request #2719 from aws/staging/06b146d1-1674-42bb-a101-f25…
376a8a7 
…ae8e089ca

Pull request: release <- staging/06b146d1-1674-42bb-a101-f25ae8e089ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cenedhryn cenedhryn cenedhryn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dagnir @cenedhryn