Moved Jackson from being an external SDK dependency to an internal dependency. #2522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millems
force-pushed
the
millem/remove-jackson
branch
from
bf169c7 to
5a05e1c
Compare
millems
commented
Jun 9, 2021
core/auth/src/main/java/software/amazon/awssdk/auth/credentials/HttpCredentialsProvider.java
Show resolved
Hide resolved
core/auth/src/main/java/software/amazon/awssdk/auth/credentials/ProcessCredentialsProvider.java
Outdated
Show resolved
Hide resolved
core/json-utils/src/main/java/software/amazon/awssdk/protocols/jsoncore/JsonNodeParser.java
Show resolved
Hide resolved
millems
force-pushed
the
millem/remove-jackson
branch
3 times, most recently
from
aaf6ada to
7cca554
Compare
1 task
millems
force-pushed
the
millem/remove-jackson
branch
from
7cca554 to
7f8789b
Compare
…pendency. Jackson-databind was removed from being a dependency (except in the code generator). Jackson-core and Jackson-dataformat-cbor were moved to shaded dependencies. This was done because Jackson versions are not 100% compatible between minor versions and keeping them up to date were problematic for SDK customers. Customers will see a change in artifact sizes. Customers which do not use Jackson-databind outside of the SDK today will see a ~1 MB artifact size decrease. Customers which do use Jackson-databind outside of the SDK will see a ~0.5 MB artifact size increase. This change required breaking inter-module (protected) APIs, so it should not be released outside of an SDK minor version bump. Customers will not be able to use older client versions with this version of the core libraries. Change summary: 1. Added 'jackson-core' and 'jackson-dataformat-cbor' which contain the SDK's shaded versions with the Jackson packages of the same names. 2. Removed 'aws-ion-protocol' module. This was not used by any public AWS services and can be re-added when service support is needed. 3. Added 'json-utils', a library for reading and parsing JSON.
millems
force-pushed
the
millem/remove-jackson
branch
from
7f8789b to
f302008
Compare
zoewangg
reviewed
Jun 11, 2021
joviegas
reviewed
Jun 11, 2021
core/json-utils/src/main/java/software/amazon/awssdk/protocols/jsoncore/JsonNode.java
Outdated
Show resolved
Hide resolved
core/auth/src/main/java/software/amazon/awssdk/auth/credentials/ProcessCredentialsProvider.java
Outdated
Show resolved
Hide resolved
...src/main/java/software/amazon/awssdk/protocols/jsoncore/internal/EmbeddedObjectJsonNode.java
Show resolved
Hide resolved
core/json-utils/src/main/java/software/amazon/awssdk/protocols/jsoncore/JsonNodeParser.java
Show resolved
Hide resolved
...src/main/java/software/amazon/awssdk/protocols/jsoncore/internal/EmbeddedObjectJsonNode.java
Outdated
Show resolved
Hide resolved
joviegas
reviewed
Jun 14, 2021
...-utils/src/main/java/software/amazon/awssdk/protocols/jsoncore/internal/BooleanJsonNode.java
Show resolved
Hide resolved
joviegas
approved these changes
Jun 15, 2021
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jackson-databind was removed from being a dependency (except in the code generator). Jackson-core and
Jackson-dataformat-cbor were moved to shaded dependencies. This was done because Jackson versions
are not 100% compatible between minor versions and keeping them up to date were problematic for SDK
customers.
Customers will see a change in artifact sizes. Customers which do not use Jackson-databind outside of
the SDK today will see a ~1 MB artifact size decrease. Customers which do use Jackson-databind outside
of the SDK will see a ~0.5 MB artifact size increase.
This change required breaking inter-module (protected) APIs, so it should not be released outside of an
SDK minor version bump. Customers will not be able to use older client versions with this version of
the core libraries.
Change summary:
Jackson packages of the same names.
service support is needed.