Netty client support for authorized proxy #2517

guillepb10 · 2021-06-08T10:22:57Z

Description

This change able the use of a secured corporate proxy to communicate with aws, into the netty async client.

Motivation and Context

So many corporations used a proxy to connect to internet. Besides this corporate usually needs a basic autentication to connect to the proxy. Until nowadays, it was impossible to used a secured coroporate proxy with netty client, couse it did not support to specify the user and password required to connect to proxy. This change makes it possible.

Testing

It has been compleated unit testing of the library to ensure the purpose of the change it is successfully met.
Besides, I have tested the change with a personal project, where I try to connect to CloudWatchLogs api behind a coporate proxy, and it succeeded.

As cloud bee shown this is a very little change, that only affect to netty-nio-client. So it must not break the current work of the client.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Checklist

License

I confirm that this pull request can be released under the Apache 2 license

codecov-commenter · 2021-06-08T11:09:49Z

Codecov Report

Merging #2517 (b590b58) into master (ebee1aa) will increase coverage by 0.00%.
The diff coverage is 96.29%.

@@            Coverage Diff            @@
##             master    #2517   +/-   ##
=========================================
  Coverage     77.74%   77.74%           
  Complexity      365      365           
=========================================
  Files          1248     1248           
  Lines         39543    39563   +20     
  Branches       3097     3098    +1     
=========================================
+ Hits          30741    30760   +19     
  Misses         7315     7315           
- Partials       1487     1488    +1

Flag	Coverage Δ
unittests	`77.74% <96.29%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ttp/nio/netty/internal/ProxyTunnelInitHandler.java	`91.93% <90.00%> (-0.66%)`	⬇️
...azon/awssdk/http/nio/netty/ProxyConfiguration.java	`82.45% <100.00%> (+2.86%)`	⬆️
...p/nio/netty/internal/AwaitCloseChannelPoolMap.java	`92.45% <100.00%> (ø)`
.../nio/netty/internal/Http1TunnelConnectionPool.java	`98.36% <100.00%> (+0.11%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c33ad01...b590b58. Read the comment docs.

guillepb10 · 2021-06-14T16:53:46Z

@dagnir First of all, sorry for disturb, but I have opened this pull request a week ago and I didn't have any feedback about it. Could you review it? Or give me any gap of time to be reviewed?

debora-ito

Made some comments in an initial review.

...netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/ProxyConfiguration.java

...c/test/java/software/amazon/awssdk/http/nio/netty/internal/AwaitCloseChannelPoolMapTest.java

...src/test/java/software/amazon/awssdk/http/nio/netty/internal/ProxyTunnelInitHandlerTest.java

…guillepb10/aws-sdk-java-v2 into feature/support-proxy-with-auth

...netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/ProxyConfiguration.java

...src/test/java/software/amazon/awssdk/http/nio/netty/internal/ProxyTunnelInitHandlerTest.java

…guillepb10/aws-sdk-java-v2 into feature/support-proxy-with-auth

guillepb10 · 2021-07-22T08:46:59Z

Hi @debora-ito , I think I have already solved your comments

sonarqubecloud · 2021-07-26T10:39:22Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

76.8% Coverage
10.7% Duplication

cenedhryn · 2021-08-19T17:35:07Z

.changes/next-release/feature-AWSSDKforJavav2-dd0c4ee.json

+    "category": "AWS SDK for Java v2", 
+    "contributor": "guillepb10", 
+    "type": "feature", 
+    "description": "Add support for autheticated corporate proxies"


autheticated -> authenticated

cenedhryn · 2021-08-19T18:53:30Z

.../src/main/java/software/amazon/awssdk/http/nio/netty/internal/Http1TunnelConnectionPool.java

@@ -120,7 +134,8 @@ private void setupChannel(Channel ch, Promise<Channel> acquirePromise) {
        if (sslHandler != null) {
            ch.pipeline().addLast(sslHandler);
        }
-        ch.pipeline().addLast(initHandlerSupplier.newInitHandler(delegate, remoteAddress, tunnelEstablishedPromise));
+        ch.pipeline().addLast(initHandlerSupplier.newInitHandler(delegate, this.proxyUser, this.proxyPassword, remoteAddress,


I'm not against using this but this module should be consistent in its usage of class members and currently this isn't used widely, so let's remove it for readability.

cenedhryn · 2021-08-19T23:35:12Z

@guillepb10 Thanks for submitting the PR, and sorry it took a while for us to fully review it. I only had some minor comments.

… into feature/support-proxy-with-auth

guillepb10 · 2021-09-06T10:40:13Z

Thank you for your feedback @cenedhryn. I've just updated the PR with your comments.

sonarqubecloud · 2021-09-09T23:58:00Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

76.8% Coverage
10.7% Duplication

debora-ito · 2021-09-10T17:39:50Z

@all-contributors please add @guillepb10 for code.

allcontributors · 2021-09-10T17:39:58Z

@debora-ito

I've put up a pull request to add @guillepb10! 🎉

next-guillermopriego and others added 4 commits June 7, 2021 18:46

feat(client): support proxy with auth into netty client

157f838

test: test with proxy auth

cf0b939

doc: add javadoc to public interface and update changelog

21bb134

Merge branch 'master' into feature/support-proxy-with-auth

63857b6

guillepb10 changed the title ~~Feature/support proxy with auth~~ Netty client support for authorized proxy Jun 8, 2021

guillepb10 and others added 2 commits June 9, 2021 09:54

Merge branch 'master' into feature/support-proxy-with-auth

2852185

doc: more javadoc

b590b58

Merge branch 'master' into feature/support-proxy-with-auth

76c0422

guillepb10 mentioned this pull request Jun 25, 2021

Netty Client Does Not Support Proxy Authentication #1432

Closed

debora-ito reviewed Jul 7, 2021

View reviewed changes

next-guillermopriego and others added 4 commits July 7, 2021 09:56

fix: fix pr comments

dee2bb4

apply codestyle

5d35750

Merge branch 'feature/support-proxy-with-auth' of https://github.com/…

d9d3490

…guillepb10/aws-sdk-java-v2 into feature/support-proxy-with-auth

Merge branch 'master' into feature/support-proxy-with-auth

e977e01

debora-ito linked an issue Jul 7, 2021 that may be closed by this pull request

Netty Client Does Not Support Proxy Authentication #1432

Closed

Merge branch 'master' into feature/support-proxy-with-auth

7cae7f5

debora-ito reviewed Jul 8, 2021

View reviewed changes

...netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/ProxyConfiguration.java Outdated Show resolved Hide resolved

debora-ito reviewed Jul 8, 2021

View reviewed changes

...netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/ProxyConfiguration.java Outdated Show resolved Hide resolved

debora-ito reviewed Jul 8, 2021

View reviewed changes

...src/test/java/software/amazon/awssdk/http/nio/netty/internal/ProxyTunnelInitHandlerTest.java Outdated Show resolved Hide resolved

next-guillermopriego and others added 4 commits July 9, 2021 08:13

fix: fix doc and equals into dto and codestyle

ab976fb

Merge branch 'feature/support-proxy-with-auth' of https://github.com/…

a0a3b8a

…guillepb10/aws-sdk-java-v2 into feature/support-proxy-with-auth

Merge branch 'master' into feature/support-proxy-with-auth

216bbf9

Merge branch 'master' into feature/support-proxy-with-auth

ffd82d7

Merge branch 'master' into feature/support-proxy-with-auth

a2732c1

cenedhryn reviewed Aug 19, 2021

View reviewed changes

debora-ito assigned cenedhryn Aug 19, 2021

next-guillermopriego added 2 commits September 6, 2021 12:38

fix: fix typo and remove use of this into field access

17df7a4

Merge remote-tracking branch 'guille/feature/support-proxy-with-auth'…

623e019

… into feature/support-proxy-with-auth

cenedhryn approved these changes Sep 8, 2021

View reviewed changes

guillepb10 and others added 3 commits September 9, 2021 10:33

Merge branch 'master' into feature/support-proxy-with-auth

3dde332

Merge branch 'master' into feature/support-proxy-with-auth

194ec44

Merge branch 'master' into feature/support-proxy-with-auth

b50d0f3

debora-ito merged commit 95e3ad9 into aws:master Sep 10, 2021

allcontributors bot mentioned this pull request Sep 10, 2021

docs: add guillepb10 as a contributor for code #2706

Merged

Netty client support for authorized proxy #2517

Netty client support for authorized proxy #2517

Uh oh!

Conversation

guillepb10 commented Jun 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

Testing

Types of changes

Checklist

License

Uh oh!

codecov-commenter commented Jun 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

guillepb10 commented Jun 14, 2021

Uh oh!

debora-ito left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

guillepb10 commented Jul 22, 2021

Uh oh!

sonarqubecloud bot commented Jul 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cenedhryn Aug 19, 2021

Choose a reason for hiding this comment

Uh oh!

cenedhryn Aug 19, 2021

Choose a reason for hiding this comment

Uh oh!

cenedhryn commented Aug 19, 2021

Uh oh!

guillepb10 commented Sep 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud bot commented Sep 9, 2021

Uh oh!

debora-ito commented Sep 10, 2021

Uh oh!

allcontributors bot commented Sep 10, 2021

Uh oh!

Uh oh!

guillepb10 commented Jun 8, 2021 •

edited

Loading

codecov-commenter commented Jun 8, 2021 •

edited

Loading

sonarqubecloud bot commented Jul 26, 2021 •

edited

Loading

guillepb10 commented Sep 6, 2021 •

edited

Loading