-
Notifications
You must be signed in to change notification settings - Fork 910
Adding high-level libraries to the changelog #2354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## master #2354 +/- ##
=========================================
Coverage 77.66% 77.67%
Complexity 366 366
=========================================
Files 1244 1244
Lines 39272 39272
Branches 3106 3106
=========================================
+ Hits 30501 30503 +2
+ Misses 7284 7282 -2
Partials 1487 1487
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -378,7 +378,7 @@ The S3 client in 2.0 is drastically different from the client in 1.11, because i | |||
| `doesBucketExistV2` | `headBucket` | | |||
| `doesObjectExist` | `headObject` | | |||
| `enableRequesterPays` | `putBucketRequestPayment` | | |||
| `generatePresignedUrl` | [Not Supported](https://github.com/aws/aws-sdk-java-v2/issues/849) | | |||
| `generatePresignedUrl` | [~~Not Supported~~](https://github.com/aws/aws-sdk-java-v2/issues/849) [S3Presigner](https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/examples-s3-presign.html) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! Should we remove the strike-through?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the strike-through indicates work, that things have changed since the last time you saw this document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's definitely beneficial. I wasn't sure if people read it multiple times for updates, and I figured the commit history exists if people want to know what's changed. I think it's one of those "fine either way" things.
…c9cc9d7f0 Pull request: release <- staging/075faebe-63f0-4f1c-98f4-7f0c9cc9d7f0
Description
Updated the 1.11 to 2.0 Changelog:
Motivation and Context
Keep the changelog up-to-date.
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsLicense