Skip to content

Adding high-level libraries to the changelog #2354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

debora-ito
Copy link
Member

Description

Updated the 1.11 to 2.0 Changelog:

  • Added DynamoDB Enhanced client and Waiters
  • Updated the status of S3 Presigned URLs

Motivation and Context

Keep the changelog up-to-date.

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-io
Copy link

Codecov Report

Merging #2354 (a8a77cc) into master (395b582) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2354   +/-   ##
=========================================
  Coverage     77.66%   77.67%           
  Complexity      366      366           
=========================================
  Files          1244     1244           
  Lines         39272    39272           
  Branches       3106     3106           
=========================================
+ Hits          30501    30503    +2     
+ Misses         7284     7282    -2     
  Partials       1487     1487           
Flag Coverage Δ Complexity Δ
unittests 77.67% <ø> (+<0.01%) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...ty/internal/IdleConnectionCountingChannelPool.java 85.36% <0.00%> (-2.44%) 0.00% <0.00%> (ø%)
...ssdk/core/internal/async/FileAsyncRequestBody.java 84.90% <0.00%> (+3.77%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 395b582...a8a77cc. Read the comment docs.

@@ -378,7 +378,7 @@ The S3 client in 2.0 is drastically different from the client in 1.11, because i
| `doesBucketExistV2` | `headBucket` |
| `doesObjectExist` | `headObject` |
| `enableRequesterPays` | `putBucketRequestPayment` |
| `generatePresignedUrl` | [Not Supported](https://github.com/aws/aws-sdk-java-v2/issues/849) |
| `generatePresignedUrl` | [~~Not Supported~~](https://github.com/aws/aws-sdk-java-v2/issues/849) [S3Presigner](https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/examples-s3-presign.html) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Should we remove the strike-through?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the strike-through indicates work, that things have changed since the last time you saw this document.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's definitely beneficial. I wasn't sure if people read it multiple times for updates, and I figured the commit history exists if people want to know what's changed. I think it's one of those "fine either way" things.

@debora-ito debora-ito merged commit 897e8ba into aws:master Mar 30, 2021
aws-sdk-java-automation added a commit that referenced this pull request Jan 27, 2023
…c9cc9d7f0

Pull request: release <- staging/075faebe-63f0-4f1c-98f4-7f0c9cc9d7f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants