CRT S3 Client PutObject

[dagnir]

Description

Motivation and Context

Testing

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Checklist

• I have read the CONTRIBUTING document
• Local run of mvn install succeeds
• My code follows the code style of this project
• My change requires a change to the Javadoc documentation
• I have updated the Javadoc documentation accordingly
• I have read the README document
• I have added tests to cover my changes
• All new and existing tests passed
• A short description of the change has been added to the CHANGELOG
• My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

• I confirm that this pull request can be released under the Apache 2 license

[dagnir]

I've doing some testing against this updated interface, and CRT doesn't seem to treat the return value the way I'd expect, given this description.

I would expect the following to work

getRequestBytes(ByteBuffer bb) {
    return false;
}

which results in getRequestBytes() being called continuously, like this:

Content length is 4 bytes
1: getRequestBytes(buffer); // returns false, buffer contains 1 byte
2: getRequestBytes(buffer); // returns false, buffer contains 1 byte
3: getRequestBytes(buffer); // returns false, buffer contains 1 byte
4: getRequestBytes(buffer); // returns true, buffer contains 1 byte

but returning false results in the request completing instead; i.e. 2-4 never happen

[dagnir]

Oops, the docs are referring to are here https://github.com/awslabs/aws-crt-java/blob/06593b80e3497a74a27b87a59a9f5c4b7c07cd56/s3-native-client/src/main/java/com/amazonaws/s3/RequestDataSupplier.java#L14-L17

[dagnir]

Discussing with CRT team about what we can do to support the use case above. For now, the implementation fills the buffer before returning

[zoewangg]

Is this only accessed by the same CRT thread?

[dagnir]

No, in my testing I saw two different threads calling getRequestData. However, if the threads ares are synchronizing between each other, so that changes made by one thread are visible by the other thread then it should be fine. I'll check with CRT

[dagnir]

Build failures due to dependency on unreleased version for CRT Java. Changes have been merged to mainline awslabs/aws-crt-java#298