Skip to content

Append user agent for retry mode #2322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2021
Merged

Conversation

Quanzzzz
Copy link
Contributor

@Quanzzzz Quanzzzz commented Mar 9, 2021

Append user agent for retry mode so we can collect the metrics of the usage of each retry mode.

Testing

A unit test is added

@codecov-io
Copy link

codecov-io commented Mar 9, 2021

Codecov Report

Merging #2322 (270b395) into master (b9bc77d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2322      +/-   ##
============================================
+ Coverage     77.64%   77.67%   +0.02%     
  Complexity      366      366              
============================================
  Files          1239     1239              
  Lines         39033    39041       +8     
  Branches       3081     3081              
============================================
+ Hits          30307    30324      +17     
+ Misses         7256     7249       -7     
+ Partials       1470     1468       -2     
Flag Coverage Δ Complexity Δ
unittests 77.67% <100.00%> (+0.02%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...rnal/http/pipeline/stages/ApplyUserAgentStage.java 95.83% <100.00%> (+0.71%) 0.00 <0.00> (ø)
...software/amazon/awssdk/core/retry/RetryPolicy.java 59.61% <100.00%> (+1.36%) 0.00 <0.00> (ø)
...ssdk/core/internal/async/FileAsyncRequestBody.java 83.01% <0.00%> (+1.88%) 0.00% <0.00%> (ø%)
...mazon/awssdk/utils/internal/MappingSubscriber.java 89.65% <0.00%> (+6.89%) 0.00% <0.00%> (ø%)
...k/core/pagination/async/ResponsesSubscription.java 88.00% <0.00%> (+16.00%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9bc77d...bdb8416. Read the comment docs.

@Quanzzzz Quanzzzz force-pushed the retry-user-agent branch 3 times, most recently from 270b395 to bbfb015 Compare March 10, 2021 00:30
@Quanzzzz Quanzzzz requested a review from zoewangg March 10, 2021 01:39
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Quanzzzz Quanzzzz merged commit fb7053e into aws:master Mar 10, 2021
aws-sdk-java-automation added a commit that referenced this pull request Jan 11, 2023
…4867210ae

Pull request: release <- staging/3a24999a-b57b-4324-a31f-3264867210ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants