Skip to content

Support versionId in S3Utilities#getUrl #2226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Jan 4, 2021

Description

Support versionId in S3Utilities#getUrl

Motivation and Context

#2224

Testing

Added new unit tests

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@zoewangg zoewangg force-pushed the zoewang/s3UtilGetUrlVersion branch from 45d300d to 77b8da8 Compare January 4, 2021 23:48
@debora-ito debora-ito linked an issue Jan 4, 2021 that may be closed by this pull request
@codecov-io
Copy link

codecov-io commented Jan 5, 2021

Codecov Report

Merging #2226 (77b8da8) into master (84ba31e) will increase coverage by 0.01%.
The diff coverage is 93.75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2226      +/-   ##
============================================
+ Coverage     77.62%   77.63%   +0.01%     
  Complexity      335      335              
============================================
  Files          1230     1230              
  Lines         38698    38713      +15     
  Branches       3044     3045       +1     
============================================
+ Hits          30038    30054      +16     
- Misses         7196     7199       +3     
+ Partials       1464     1460       -4     
Flag Coverage Δ Complexity Δ
unittests 77.63% <93.75%> (+0.01%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...amazon/awssdk/services/s3/model/GetUrlRequest.java 76.66% <92.30%> (+3.75%) 0.00 <0.00> (ø)
...oftware/amazon/awssdk/services/s3/S3Utilities.java 93.75% <100.00%> (+0.30%) 0.00 <0.00> (ø)
...ttp/nio/netty/internal/nrs/HttpStreamsHandler.java 60.76% <0.00%> (-3.85%) 0.00% <0.00%> (ø%)
...http/nio/netty/internal/nrs/HandlerSubscriber.java 82.75% <0.00%> (+3.44%) 0.00% <0.00%> (ø%)
...nio/netty/internal/OldConnectionReaperHandler.java 90.90% <0.00%> (+9.09%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84ba31e...026da05. Read the comment docs.

@zoewangg zoewangg force-pushed the zoewang/s3UtilGetUrlVersion branch from 77b8da8 to 026da05 Compare January 5, 2021 00:32
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.4% 94.4% Coverage
0.0% 0.0% Duplication

@zoewangg zoewangg merged commit 27dca5d into master Jan 5, 2021
@zoewangg zoewangg deleted the zoewang/s3UtilGetUrlVersion branch January 5, 2021 18:27
aws-sdk-java-automation added a commit that referenced this pull request Oct 28, 2022
…c4c5a7481

Pull request: release <- staging/03b3d6aa-cf67-4db5-89f5-8f2c4c5a7481
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 GetUrlRequest for S3Utiltiies does not support version
3 participants