Skip to content

Fix a wrong javadoc example in S3Presigner #2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 30, 2020

Conversation

Quanzzzz
Copy link
Contributor

@Quanzzzz Quanzzzz commented Dec 29, 2020

Fix a minor error in the example of the javadoc in S3Presigner.

Description

Found this typo in the example of using the S3Presigner. The GetObjectPresignRequest.getObjectRequest() means to take the getObjectRequest initialized above, but it just took a simple request here. Correcting this typo.

Motivation and Context

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link

codecov-io commented Dec 29, 2020

Codecov Report

Merging #2222 (54b9fe7) into master (f700c4a) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2222      +/-   ##
============================================
- Coverage     77.59%   77.58%   -0.01%     
  Complexity      335      335              
============================================
  Files          1230     1230              
  Lines         38697    38697              
  Branches       3043     3043              
============================================
- Hits          30026    30025       -1     
- Misses         7211     7212       +1     
  Partials       1460     1460              
Flag Coverage Δ Complexity Δ
unittests 77.58% <ø> (-0.01%) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...azon/awssdk/services/s3/presigner/S3Presigner.java 35.00% <ø> (ø) 0.00 <0.00> (ø)
...k/core/pagination/async/ResponsesSubscription.java 72.00% <0.00%> (-16.00%) 0.00% <0.00%> (ø%)
...mazon/awssdk/utils/internal/MappingSubscriber.java 82.75% <0.00%> (-6.90%) 0.00% <0.00%> (ø%)
...ty/internal/IdleConnectionCountingChannelPool.java 85.36% <0.00%> (-2.44%) 0.00% <0.00%> (ø%)
...ssdk/core/internal/async/FileAsyncRequestBody.java 84.76% <0.00%> (+3.80%) 0.00% <0.00%> (ø%)
...nio/netty/internal/OldConnectionReaperHandler.java 90.90% <0.00%> (+9.09%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f700c4a...54b9fe7. Read the comment docs.

@Quanzzzz Quanzzzz merged commit 8586a54 into aws:master Dec 30, 2020
aws-sdk-java-automation added a commit that referenced this pull request Oct 26, 2022
…d8f72d583

Pull request: release <- staging/68675c51-0991-4415-905c-f0dd8f72d583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants