Skip to content

Add validation for new streams #2206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Dec 16, 2020

Description

Validation is only for Kinesis, Transcribe Streaming, since they have existing
streams generated with the old style.

Motivation and Context

Testing

Remove streams from the Kinesis and Transcribe Stream mappings and attempt to generate.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir dagnir force-pushed the prevent-new-style-streams branch from 511074d to 321bc25 Compare December 16, 2020 18:17
Validation is only for Kinesis, Transcribe Streaming, since they have existing
streams generated with the old style.
@dagnir dagnir force-pushed the prevent-new-style-streams branch from 321bc25 to 3e2afa9 Compare December 16, 2020 18:45
@sonarqubecloud
Copy link

@dagnir dagnir merged commit b8dd326 into aws:dongie/eventstream-visitors-fix Dec 16, 2020
@dagnir dagnir deleted the prevent-new-style-streams branch December 16, 2020 19:52
aws-sdk-java-automation added a commit that referenced this pull request Oct 18, 2022
…1f0576ff2

Pull request: release <- staging/05916ecd-529c-4c44-a885-e971f0576ff2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants