Skip to content

Add legacy gen for MedicalTranscriptResultStream #2203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Dec 15, 2020

Description

MedicalTranscriptResultStream$TrancriptEvent was released with the existing code
generation scheme so it needs to be customized.

Motivation and Context

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

MedicalTranscriptResultStream$TrancriptEvent was released with the existing code
generation scheme so it needs to be customized.
@dagnir
Copy link
Contributor Author

dagnir commented Dec 15, 2020

Diff for generated files: https://gist.github.com/dagnir/178f522516086cdd48366cff841aed73

@dagnir
Copy link
Contributor Author

dagnir commented Dec 15, 2020

This is the only new evenstream that I could find:

rg -F '"eventstream"' services/
services/transcribestreaming/src/main/resources/codegen-resources/service-2.json
7:    "protocolSettings":{"h2":"eventstream"},
91:      "eventstream":true
324:      "eventstream":true
745:      "eventstream":true

services/kinesis/src/main/resources/codegen-resources/service-2.json
8:    "protocolSettings":{"h2":"eventstream"},
1946:      "eventstream":true

services/s3/src/main/resources/codegen-resources/service-2.json
8744:      "eventstream":true

@dagnir dagnir merged commit a1ad3aa into aws:dongie/eventstream-visitors-fix Dec 16, 2020
@dagnir dagnir deleted the medicaltranscriptstream branch December 16, 2020 00:15
aws-sdk-java-automation added a commit that referenced this pull request Oct 14, 2022
…edf350b4c

Pull request: release <- staging/be31fe3a-5a91-41d3-88f8-7dcedf350b4c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants