Expose event-type in stream interface #2176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagnir
force-pushed
the
sdk-event-type-getter
branch
from
482176c to
c39678a
Compare
zoewangg
reviewed
Dec 2, 2020
codegen/src/main/java/software/amazon/awssdk/codegen/poet/model/AwsServiceModel.java
Outdated
Show resolved
Hide resolved
...n/src/test/resources/software/amazon/awssdk/codegen/poet/model/sharedstream/eventstream.java
Outdated
Show resolved
Hide resolved
dagnir
force-pushed
the
sdk-event-type-getter
branch
4 times, most recently
from
425ac63 to
a839ef8
Compare
dagnir
force-pushed
the
sdk-event-type-getter
branch
from
a839ef8 to
79caff9
Compare
dagnir
force-pushed
the
sdk-event-type-getter
branch
from
79caff9 to
32cd8d6
Compare
|
Kudos, SonarCloud Quality Gate passed! |
13 tasks
zoewangg
reviewed
Dec 4, 2020
| * {@code EventStream#EventTwo} event. Do not use this class directly. Instead, use the static builder methods on | ||
| * {@link software.amazon.awssdk.services.jsonprotocoltests.model.EventStream}. | ||
| * A specialization of {@code software.amazon.awssdk.services.json.model.EventTwo} that represents the | ||
| * {@code EventStream$EventTwo} event. Do not use this class directly. Instead, use the static builder methods on |
There was a problem hiding this comment.
Typo? EventStream$EventTwo -> EventStream#EventTwo
There was a problem hiding this comment.
No, decided to use the C2j notation
| */ | ||
| @SdkInternalApi | ||
| @Generated("software.amazon.awssdk:codegen") | ||
| public final class DefaultSecondEventTwo extends EventTwo { | ||
| public final class DefaultSecondeventtwo extends EventTwo { |
There was a problem hiding this comment.
Is this change intentional? Shouldn't it be DefaultSecondEventTwo?
There was a problem hiding this comment.
It's a little confusing, but this one corresponds to this event
zoewangg
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense