Skip to content

Immutables support in DynamoDb Enhanced Client #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2020

Conversation

bmaizels
Copy link
Contributor

See README.md changes for description of new features. Fulfills #1801

Testing

New tests were written. All tests pass.

License

  • I confirm that this pull request can be released under the Apache 2 license

@codecov-commenter
Copy link

Codecov Report

Merging #2012 into master will increase coverage by 0.06%.
The diff coverage is 87.29%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2012      +/-   ##
============================================
+ Coverage     76.92%   76.98%   +0.06%     
  Complexity      225      225              
============================================
  Files          1107     1119      +12     
  Lines         33507    33966     +459     
  Branches       2573     2624      +51     
============================================
+ Hits          25774    26148     +374     
- Misses         6453     6515      +62     
- Partials       1280     1303      +23     
Flag Coverage Δ Complexity Δ
#unittests 76.98% <87.29%> (+0.06%) 225.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...amazon/awssdk/enhanced/dynamodb/TableMetadata.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...k/enhanced/dynamodb/internal/mapper/StaticKey.java 55.55% <55.55%> (ø) 0.00 <0.00> (?)
...enhanced/dynamodb/internal/mapper/StaticIndex.java 66.66% <66.66%> (ø) 0.00 <0.00> (?)
...enhanced/dynamodb/mapper/ImmutableTableSchema.java 79.64% <79.64%> (ø) 0.00 <0.00> (?)
...dk/enhanced/dynamodb/mapper/StaticTableSchema.java 81.13% <81.81%> (-9.05%) 0.00 <0.00> (ø)
...db/internal/mapper/ResolvedImmutableAttribute.java 87.09% <87.09%> (ø) 0.00 <0.00> (?)
...ed/dynamodb/mapper/StaticImmutableTableSchema.java 88.55% <88.55%> (ø) 0.00 <0.00> (?)
...modb/internal/immutable/ImmutableIntrospector.java 89.47% <89.47%> (ø) 0.00 <0.00> (?)
.../enhanced/dynamodb/mapper/StaticTableMetadata.java 82.00% <92.85%> (+8.92%) 0.00 <0.00> (ø)
...ssdk/enhanced/dynamodb/mapper/StaticAttribute.java 94.11% <95.65%> (-5.89%) 0.00 <0.00> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fcc51d...09d6fa6. Read the comment docs.

@bmaizels bmaizels requested a review from cenedhryn August 31, 2020 17:13
@bmaizels bmaizels force-pushed the bmaizels/ddbenhanced-immutables-poc branch 2 times, most recently from 0e74c84 to 1d08b9f Compare September 1, 2020 01:18
@bmaizels bmaizels force-pushed the bmaizels/ddbenhanced-immutables-poc branch 2 times, most recently from 9ce7a3f to 6f1405f Compare September 1, 2020 19:11
Copy link
Contributor

@cenedhryn cenedhryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also went through Sonarcloud issues, it misinterprets the Optional.ifPresent().

@bmaizels bmaizels force-pushed the bmaizels/ddbenhanced-immutables-poc branch from 6f1405f to 08945b9 Compare September 1, 2020 23:34
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2020

SonarCloud Quality Gate failed.

Bug C 7 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 30 Code Smells

87.6% 87.6% Coverage
1.1% 1.1% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@bmaizels bmaizels merged commit 98a67d1 into master Sep 2, 2020
@bmaizels bmaizels deleted the bmaizels/ddbenhanced-immutables-poc branch September 2, 2020 00:05
aws-sdk-java-automation pushed a commit that referenced this pull request Jul 14, 2022
Fixed possible security issue in s  operation where files could be do…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants