Skip to content

Updated DynamoDBEnhancedClient to support '0' and '1' as valid boolean values #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

millems
Copy link
Contributor

@millems millems commented Jul 8, 2020

The 1.11.x DynamoDB mapper persisted booleans as 0s and 1s (in the 'number' type). For backwards-compatibility, we should be able to read these values. The values will be converted to boolean types if they are written back to DynamoDB.

Fixes #1912

…n values.

The 1.11.x DynamoDB mapper persisted booleans as 0s and 1s (in the 'number' type). For backwards-compatibility, we should be able to read these values. The values will be converted to boolean types if they are written back to DynamoDB.

Fixes #1912
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 8, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

77.8% 77.8% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@millems millems merged commit cd8c93a into master Jul 8, 2020
aws-sdk-java-automation added a commit that referenced this pull request Feb 28, 2022
…d24a1da2a

Pull request: release <- staging/1e29950a-0f41-4e33-8e44-817d24a1da2a
@millems millems deleted the millem/better-boolean-mapping branch October 19, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DynamoDB Enhanced BooleanAttributeConverter cannot convert N value of 0 and 1 to Boolean
3 participants