Skip to content

Fixed wrong Mimetype result for null fileName and deleted wrongly pasted javadocs #1901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 15, 2020

Conversation

Quanzzzz
Copy link
Contributor

@Quanzzzz Quanzzzz commented Jun 15, 2020

Fixed wrong Mimetype result for null fileName to keep consistency with our API contract;
Deleted wrongly pasted javadocs;

Motivation and Context

#1811

Testing

There is no newly added unit test for this change because it's impossible to set the fileName as null here in the path.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

License

  • I confirm that this pull request can be released under the Apache 2 license

@Quanzzzz Quanzzzz linked an issue Jun 15, 2020 that may be closed by this pull request
@Quanzzzz Quanzzzz requested a review from bmaizels June 15, 2020 21:09
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2020

Codecov Report

Merging #1901 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1901      +/-   ##
============================================
+ Coverage     76.22%   76.26%   +0.04%     
  Complexity      187      187              
============================================
  Files          1076     1076              
  Lines         32504    32573      +69     
  Branches       2546     2569      +23     
============================================
+ Hits          24775    24841      +66     
- Misses         6468     6474       +6     
+ Partials       1261     1258       -3     
Flag Coverage Δ Complexity Δ
#unittests 76.26% <100.00%> (+0.04%) 187.00 <0.00> (ø)
Impacted Files Coverage Δ Complexity Δ
...are/amazon/awssdk/core/internal/util/Mimetype.java 85.36% <100.00%> (+4.87%) 0.00 <0.00> (ø)
...tomization/CodegenCustomizationProcessorChain.java 81.81% <0.00%> (-8.19%) 0.00% <0.00%> (ø%)
...on/awssdk/protocols/ion/AwsIonProtocolFactory.java 72.72% <0.00%> (-5.06%) 0.00% <0.00%> (ø%)
.../software/amazon/awssdk/core/sync/RequestBody.java 90.00% <0.00%> (-3.11%) 0.00% <0.00%> (ø%)
...ftware/amazon/awssdk/codegen/internal/Jackson.java 59.09% <0.00%> (-2.82%) 0.00% <0.00%> (ø%)
...on/awssdk/codegen/internal/DocumentationUtils.java 75.00% <0.00%> (-2.42%) 0.00% <0.00%> (ø%)
...nhanced/dynamodb/extensions/WriteModification.java 52.00% <0.00%> (-2.17%) 0.00% <0.00%> (ø%)
...ices/s3/internal/presigner/DefaultS3Presigner.java 88.88% <0.00%> (-1.92%) 0.00% <0.00%> (ø%)
...rvices/s3/internal/ConfiguredS3SdkHttpRequest.java 46.15% <0.00%> (-1.85%) 0.00% <0.00%> (ø%)
...retry/DefaultTokenBucketExceptionCostFunction.java 50.00% <0.00%> (-1.73%) 0.00% <0.00%> (ø%)
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b5f66d...fbfaa08. Read the comment docs.

@Quanzzzz Quanzzzz force-pushed the fix-mime-type-null branch from 8c17191 to e459771 Compare June 15, 2020 22:23
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@Quanzzzz Quanzzzz merged commit 9772428 into aws:master Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mimetype.getMimeType() incorrectly returns null
3 participants