Skip to content

Fix missing token #1893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2020
Merged

Fix missing token #1893

merged 3 commits into from
Jun 12, 2020

Conversation

Quanzzzz
Copy link
Contributor

Resolved more comments and added a changelog for #1891.

License

  • I confirm that this pull request can be released under the Apache 2 license

@Quanzzzz Quanzzzz requested a review from zoewangg June 12, 2020 00:37
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2020

Codecov Report

Merging #1893 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1893      +/-   ##
============================================
+ Coverage     76.22%   76.26%   +0.03%     
  Complexity      187      187              
============================================
  Files          1076     1076              
  Lines         32574    32573       -1     
  Branches       2569     2569              
============================================
+ Hits          24831    24841      +10     
+ Misses         6484     6476       -8     
+ Partials       1259     1256       -3     
Flag Coverage Δ Complexity Δ
#unittests 76.26% <ø> (+0.03%) 187.00 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
...amodb/model/TransactWriteItemsEnhancedRequest.java 84.44% <ø> (-0.34%) 0.00 <0.00> (ø)
...mazon/awssdk/utils/async/DelegatingSubscriber.java 77.77% <0.00%> (-22.23%) 0.00% <0.00%> (ø%)
...k/core/pagination/async/ResponsesSubscription.java 68.00% <0.00%> (-16.00%) 0.00% <0.00%> (ø%)
...ssdk/core/internal/async/FileAsyncRequestBody.java 87.61% <0.00%> (+2.85%) 0.00% <0.00%> (ø%)
.../http/nio/netty/internal/NettyRequestExecutor.java 74.24% <0.00%> (+5.55%) 0.00% <0.00%> (ø%)
...nio/netty/internal/OldConnectionReaperHandler.java 90.90% <0.00%> (+9.09%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e868c53...24b3c3d. Read the comment docs.

@Quanzzzz Quanzzzz merged commit 117b2fe into aws:master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants