-
Notifications
You must be signed in to change notification settings - Fork 916
Added missing clientRequestToken to TransactWriteItemsEnhancedRequest #1891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,27 +20,34 @@ | |
import static org.hamcrest.Matchers.is; | ||
import static org.hamcrest.Matchers.notNullValue; | ||
import static org.hamcrest.Matchers.nullValue; | ||
import static org.junit.Assert.assertEquals; | ||
import static software.amazon.awssdk.enhanced.dynamodb.functionaltests.models.FakeItem.createUniqueFakeItem; | ||
import static software.amazon.awssdk.enhanced.dynamodb.internal.AttributeValues.stringValue; | ||
|
||
import com.sun.org.apache.xpath.internal.ExtensionsProvider; | ||
import java.util.Arrays; | ||
import java.util.List; | ||
import java.util.Map; | ||
import java.util.UUID; | ||
import org.junit.Before; | ||
import org.junit.Test; | ||
import org.junit.runner.RunWith; | ||
import org.mockito.Mock; | ||
import org.mockito.junit.MockitoJUnitRunner; | ||
import software.amazon.awssdk.enhanced.dynamodb.DynamoDbEnhancedClient; | ||
import software.amazon.awssdk.enhanced.dynamodb.DynamoDbEnhancedClientExtension; | ||
import software.amazon.awssdk.enhanced.dynamodb.DynamoDbTable; | ||
import software.amazon.awssdk.enhanced.dynamodb.Expression; | ||
import software.amazon.awssdk.enhanced.dynamodb.Key; | ||
import software.amazon.awssdk.enhanced.dynamodb.functionaltests.models.FakeItem; | ||
import software.amazon.awssdk.enhanced.dynamodb.internal.client.ExtensionResolver; | ||
import software.amazon.awssdk.enhanced.dynamodb.internal.operations.TransactWriteItemsOperation; | ||
import software.amazon.awssdk.services.dynamodb.DynamoDbClient; | ||
import software.amazon.awssdk.services.dynamodb.model.AttributeValue; | ||
import software.amazon.awssdk.services.dynamodb.model.Delete; | ||
import software.amazon.awssdk.services.dynamodb.model.Put; | ||
import software.amazon.awssdk.services.dynamodb.model.TransactWriteItem; | ||
import software.amazon.awssdk.services.dynamodb.model.TransactWriteItemsRequest; | ||
|
||
@RunWith(MockitoJUnitRunner.class) | ||
public class TransactWriteItemsEnhancedRequestTest { | ||
|
@@ -167,6 +174,17 @@ public void builder_maximal_builder_style() { | |
assertThat(builtObject.transactWriteItems().get(3).conditionCheck().key().get("id").s(), is(fakeItem.getId())); | ||
} | ||
|
||
@Test | ||
public void setClientRequestTokenTest() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit, the naming pattern for most of our unit tests is something like: given_when_then, so maybe There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was trying to figure out a name in this pattern but I failed so I just used the current simple one lol. Will change it. |
||
String token = UUID.randomUUID().toString(); | ||
TransactWriteItemsEnhancedRequest enhancedRequest = TransactWriteItemsEnhancedRequest.builder() | ||
.clientRequestToken(token) | ||
.build(); | ||
DynamoDbEnhancedClientExtension extension = ExtensionResolver.resolveExtensions(ExtensionResolver.defaultExtensions()); | ||
TransactWriteItemsRequest request = TransactWriteItemsOperation.create(enhancedRequest).generateRequest(extension); | ||
assertEquals(token, request.clientRequestToken()); | ||
} | ||
|
||
private List<TransactWriteItem> getTransactWriteItems(FakeItem fakeItem) { | ||
final Map<String, AttributeValue> fakeItemMap = FakeItem.getTableSchema().itemToMap(fakeItem, true); | ||
|
||
|
Uh oh!
There was an error while loading. Please reload this page.