Skip to content

Add setup code for API call metrics for sync #1872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2020
Merged

Add setup code for API call metrics for sync #1872

merged 1 commit into from
Jun 5, 2020

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Jun 2, 2020

Description

Part of Implementing core metrics. This PR adds code to set up the metric collection and publishing for sync API calls.

Motivation and Context

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir dagnir force-pushed the core-metrics branch 2 times, most recently from f014d7f to 14e4818 Compare June 3, 2020 19:50
@bmaizels bmaizels self-requested a review June 3, 2020 21:46
@dagnir dagnir changed the title add setup code for API call metrics for sync Add setup code for API call metrics for sync Jun 4, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 4, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

86.7% 86.7% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@dagnir dagnir merged commit 4c8dd25 into aws:sdk-metrics-development-2 Jun 5, 2020
aws-sdk-java-automation added a commit that referenced this pull request Dec 9, 2021
@aws-sdk-java-automation
Merge pull request #1872 from aws/staging/b42c3a87-b4bb-4eaf-99cd-e01…
2f89e33 
…176d2f53d

Pull request: release <- staging/b42c3a87-b4bb-4eaf-99cd-e01176d2f53d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmaizels bmaizels bmaizels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dagnir @bmaizels