Add apache HTTP request stats #1863
Conversation
...clients/apache-client/src/main/java/software/amazon/awssdk/http/apache/ApacheHttpClient.java
Outdated
Show resolved
Hide resolved
http-client-spi/src/main/java/software/amazon/awssdk/http/HttpMetrics.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * The maximum number of connections that will be pooled by the HTTP client. | ||
| */ | ||
| public static final SdkMetric<Integer> MAX_CONNECTIONS = metric("MaxConnections", Integer.class); |
There was a problem hiding this comment.
Do we need to namespace all sdk metrics?
There was a problem hiding this comment.
I think the issue with that is if you want to "pretty print" the metrics, or write your own publisher, there's no easy way to just get the metric name
| /** | ||
| * The maximum number of connections that will be pooled by the HTTP client. | ||
| */ | ||
| public static final SdkMetric<Integer> MAX_CONNECTIONS = metric("MaxConnections", Integer.class); |
There was a problem hiding this comment.
Do we want to differentiate h2 max connection from it? Is it worth creating a new class for all h2 http metrics such as window size, max streams, etc?
There was a problem hiding this comment.
Yeah I think we should create additional metrics for H2 specific things; perhaps per-connection metrics?
Can't do this yet unfortunately until all the other things are hooked up in the request pipeline and codegen so that an SDK client actually creates a collector and passes it to the HTTP client |
|
SonarCloud Quality Gate failed.
|
Revert "[JUnit 5] Migrate some parameterized tests to JUnit 5 (#2880)"
Description
Motivation and Context
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense