-
Notifications
You must be signed in to change notification settings - Fork 910
Expose the extendedRequestId from SdkServiceException #1798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @millems, could you please take a look at this? Thanks. |
core/aws-core/src/main/java/software/amazon/awssdk/awscore/exception/AwsServiceException.java
Outdated
Show resolved
Hide resolved
…rovided to support to investigate issues
SonarCloud Quality Gate failed.
|
Codecov Report
@@ Coverage Diff @@
## master #1798 +/- ##
============================================
- Coverage 76.29% 76.27% -0.03%
Complexity 187 187
============================================
Files 1074 1074
Lines 32450 32469 +19
Branches 2550 2550
============================================
+ Hits 24759 24767 +8
- Misses 6438 6446 +8
- Partials 1253 1256 +3
Continue to review full report at Codecov.
|
…39c285ed2 Pull request: release <- staging/91137235-be6c-4a4d-a848-2d539c285ed2
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1798 +/- ##
============================================
- Coverage 76.29% 76.27% -0.03%
Complexity 187 187
============================================
Files 1074 1074
Lines 32450 32469 +19
Branches 2550 2550
============================================
+ Hits 24759 24767 +8
- Misses 6438 6446 +8
- Partials 1253 1256 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Adds a new
extendedRequestId
property to theSdkServiceException
class and includes it in the contents of AwsServiceException messages.Motivation and Context
Currently the only way to access this information from the exception is via the headers supplied by the
SdkHttpResponse
in the exception'serrorDetails
. However when the AWS client is automatically retrying and causing my Lambda function to timeout due to the added time it takes to retry, I have no way to access this information. AWS support requires this information in order to deep dive issues for some services such as S3.Testing
Ran mvn clean install and the build succeeded.
Types of changes
Checklist
mvn install
succeedsLicense