Skip to content

Integrating AWS CRT 0.5.1 into aws-crt-dev-preview #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

rccarper
Copy link
Contributor

@rccarper rccarper commented Apr 3, 2020

Description

Details about the changes that I made in addition to the above branches:

  • This points the SDK to the latest build of the Java CRT available in Maven, ie, 0.5.1.
  • This required updating a handful of places where the API has changed.
  • Fixes for check-style errors.
  • I'm currently relying on the existing unit tests invoked by mvn clean install, and would be open to any other means of validating these changes if someone knows better.
  • Possible point for API discussion: the AwsCrtAsyncHttpClient now takes an EventLoopGroup and HostResolver via its builder. It would be possible to have the client create these objects itself, making a simpler experience for the user. However, because this does add the cost of an EventLoopGroup and HostResolver to each created AwsCrtAsyncHttpClient, and handling it for them potentially hides that cost, it seemed better to have the user explicitly specify their own. For example, a customer may use a pattern that creates a large number of clients, not realizing each client is spinning up an EventLoopGroup and HostResolver.

Testing

mvn clean install

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

AWS and others added 30 commits March 3, 2020 19:05
…t for tags and tagging on resource creation.
…111437eea96

Pull request: release <- staging/f82f336e-daf3-4f40-aa3e-4111437eea96
…duces support for integrating recommender models with email, push notification, and SMS message templates. You can now use these types of templates to connect to recommender models and add personalized recommendations to messages that you send from campaigns and journeys.
…2dacb5e05fc

Pull request: release <- staging/859630d5-a0d0-4d86-8866-12dacb5e05fc
…Index, EnhancedLocalSecondaryIndex and Expression. Added missing javadocs
…icating the instance's local IP address involved in the threat.
…ing a KMS key to your cluster for envelope encryption of Kubernetes secrets.
…N Endpoints with a specified VPC and Security Group. Additionally, you can modify these attributes when modifying the endpoint.
…8a7d6909583

Pull request: release <- staging/44a63447-8309-4af0-a33a-08a7d6909583
…AWS accounts. Customers can use AWS Resource Access Manager to share their Mesh with other accounts in their organization to connection applications within a single service mesh. See https://docs.aws.amazon.com/app-mesh/latest/userguide/sharing.html for details.
… in PutSigningProfile requests, adding two more enum fields, JSONEmbedded and JSONDetached. This release also extends the length limit of SigningProfile name from 20 to 64.
…tpostArn if the finding is generated for an AWS Outposts EC2 host.
…with a self-service option to enable Local Zones.
alexw91 and others added 28 commits April 2, 2020 22:15
Factoring out EventLoopGroup/HostResolver from client constructor, fixing bug reported by Sonar
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 3, 2020

SonarCloud Quality Gate failed.

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 17 Code Smells

80.5% 80.5% Coverage
3.4% 3.4% Duplication

@rccarper rccarper closed this Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.