Skip to content

DDB Enhanced: updates README with bean examples #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2020

Conversation

cenedhryn
Copy link
Contributor

Description

Adds sections for the StaticTableSchema and BeanTableSchema, including usage of

  • AttributeConverterProviders
  • AttributeConverters
  • Flattning and extending beans
  • Ignoring and including bean attributes

@cenedhryn cenedhryn requested a review from bmaizels March 20, 2020 21:17
Comment on lines 299 to 300
converterProvider1.class,
converterProvider2.class,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capital C?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

Comment on lines +448 to +450
You can flatten as many different eligible classes as you like using the flatten annotation.
The only constraints are that attributes must not have the same name when they are being rolled
together, and there must never be more than one partition key, sort key or table name.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move this text underneath the StaticTableSchema example.

@codecov-io
Copy link

codecov-io commented Mar 31, 2020

Codecov Report

Merging #1731 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1731      +/-   ##
============================================
+ Coverage     76.24%   76.27%   +0.03%     
  Complexity      182      182              
============================================
  Files          1070     1070              
  Lines         32225    32225              
  Branches       2520     2520              
============================================
+ Hits          24569    24579      +10     
+ Misses         6415     6404      -11     
- Partials       1241     1242       +1     
Flag Coverage Δ Complexity Δ
#unittests 76.27% <ø> (+0.03%) 182.00 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
...o/netty/internal/nrs/HttpStreamsClientHandler.java 67.79% <0.00%> (+1.69%) 0.00% <0.00%> (ø%)
...ssdk/core/internal/async/FileAsyncRequestBody.java 84.76% <0.00%> (+3.80%) 0.00% <0.00%> (ø%)
...ttp/nio/netty/internal/nrs/HttpStreamsHandler.java 64.61% <0.00%> (+3.84%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be3eb1b...5eb3c74. Read the comment docs.

@cenedhryn cenedhryn force-pushed the salande/enhanced-ddb-annotation-readme branch from e67302b to 5eb3c74 Compare April 1, 2020 18:32
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@cenedhryn cenedhryn merged commit 1ce6446 into master Apr 1, 2020
@cenedhryn cenedhryn deleted the salande/enhanced-ddb-annotation-readme branch April 1, 2020 20:35
aws-sdk-java-automation added a commit that referenced this pull request Oct 1, 2021
…a56ad676b

Pull request: release <- staging/4e91a7a2-23ac-4046-93b8-dada56ad676b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants