Skip to content

Improved messaging for all UnknownHostExceptions. Added ServiceMetadata.servicePartitions() #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2020

Conversation

millems
Copy link
Contributor

@millems millems commented Jan 21, 2020

  1. Removed IAM-specific interceptor for UnknownHostExceptions.
  2. Added an interceptor for all services that provide additional helpful details on UnknownHostExceptions.
  3. Added ServiceMetadata.servicePartitions() to get partition metadata for a specific service. This is used to provide region hints for global services when customers get an UnknownHostException.
  4. Remove hard-coded elasticache service metadata, and return to generating it.
  5. Add 'aws.s3UseUsEast1RegionalEndpoint' as a system-property equivalent of AWS_S3_US_EAST_1_REGIONAL_ENDPOINT

…ta.servicePartitions().

1. Removed IAM-specific interceptor for UnknownHostExceptions.
2. Added an interceptor for all services that provide additional helpful details on UnknownHostExceptions.
3. Added ServiceMetadata.servicePartitions() to get partition metadata for a specific service. This is used to provide region hints for global services when customers get an UnknownHostException.
4. Remove hard-coded elasticache service metadata, and return to generating it.
5. Add 'aws.s3UseUsEast1RegionalEndpoint' as a system-property equivalent of `AWS_S3_US_EAST_1_REGIONAL_ENDPOINT`
@codecov-io
Copy link

codecov-io commented Jan 21, 2020

Codecov Report

Merging #1602 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1602   +/-   ##
=========================================
  Coverage     75.75%   75.75%           
  Complexity      638      638           
=========================================
  Files           899      899           
  Lines         28213    28213           
  Branches       2229     2229           
=========================================
  Hits          21373    21373           
  Misses         5821     5821           
  Partials       1019     1019
Flag Coverage Δ Complexity Δ
#unittests 75.75% <ø> (ø) 638 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9629447...0937a6d. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@millems millems merged commit e748cb4 into master Jan 21, 2020
millems added a commit that referenced this pull request Jan 21, 2020
…-improvements"

This reverts commit e748cb4, reversing
changes made to dff6955.
@millems millems deleted the millem/global-service-error-improvements branch January 21, 2020 20:54
millems added a commit that referenced this pull request Jan 21, 2020
…-improvements"

This reverts commit e748cb4, reversing
changes made to dff6955.
aws-sdk-java-automation added a commit that referenced this pull request Aug 11, 2021
…2be34975e

Pull request: release <- staging/5b0ed209-69d7-4ce6-b90e-6ce2be34975e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants