Skip to content

DynamoDb mapper: non-blocking asynchronous support for all operations #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

bmaizels
Copy link
Contributor

@bmaizels bmaizels commented Jan 20, 2020

Description

Added asynchronous implementations and interfaces for all mapper classes: DynamoDbAsyncMappedDatabase, DynamoDbAsyncMappedTable and DynamoDbAsyncMappedIndex. All operations support both modes: synchronous and non-blocking asynchronous.

Motivation and Context

Some customers like to make use of our non-blocking asynchronous SDK libraries. This introduces support for non-blocking asynchronous use of the DynamoDb Mapper which is really just an extension of the DynamoDb module in the SDK.

Testing

Unit tests and functional tests were added and all pass.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@bmaizels bmaizels force-pushed the bmaizels/ddb-mapper-async branch 2 times, most recently from a344976 to 5bb5ee9 Compare January 20, 2020 23:45
@bmaizels bmaizels requested a review from zoewangg January 20, 2020 23:47
@codecov-io
Copy link

codecov-io commented Jan 21, 2020

Codecov Report

Merging #1600 into master will decrease coverage by 0.09%.
The diff coverage is 62.91%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #1600     +/-   ##
===========================================
- Coverage     75.79%   75.69%   -0.1%     
- Complexity      638      684     +46     
===========================================
  Files           899      907      +8     
  Lines         28231    28385    +154     
  Branches       2231     2255     +24     
===========================================
+ Hits          21397    21487     +90     
- Misses         5817     5876     +59     
- Partials       1017     1022      +5
Flag Coverage Δ Complexity Δ
#unittests 75.69% <62.91%> (-0.1%) 684 <72> (+46)
Impacted Files Coverage Δ Complexity Δ
...dynamodb/mappingclient/core/TransformIterator.java 100% <ø> (ø) 4 <0> (ø) ⬇️
...ensions/dynamodb/mappingclient/MappedDatabase.java 100% <ø> (ø) 1 <0> (ø) ⬇️
...dynamodb/mappingclient/core/TransformIterable.java 100% <ø> (ø) 3 <0> (ø) ⬇️
...nsions/dynamodb/mappingclient/MapperExtension.java 50% <ø> (ø) 1 <0> (ø) ⬇️
.../awssdk/extensions/dynamodb/mappingclient/Key.java 53.84% <ø> (ø) 8 <0> (ø) ⬇️
...extensions/dynamodb/mappingclient/TableSchema.java 100% <ø> (ø) 1 <0> (ø) ⬇️
...modb/mappingclient/PaginatedDatabaseOperation.java 0% <0%> (ø) 0 <0> (?)
...ensions/dynamodb/mappingclient/IndexOperation.java 50% <0%> (-50%) 1 <0> (ø)
...amodb/mappingclient/operations/BatchWriteItem.java 70% <0%> (-1.43%) 6 <0> (ø)
...nsions/dynamodb/mappingclient/operations/Scan.java 56.14% <100%> (ø) 9 <2> (ø) ⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 732749f...23e1120. Read the comment docs.

@bmaizels bmaizels requested a review from cenedhryn January 21, 2020 19:56
@bmaizels bmaizels force-pushed the bmaizels/ddb-mapper-async branch from 5bb5ee9 to b7e6776 Compare January 21, 2020 23:33
@cenedhryn cenedhryn self-requested a review January 22, 2020 00:05
@bmaizels bmaizels force-pushed the bmaizels/ddb-mapper-async branch from b7e6776 to 247f855 Compare January 22, 2020 00:29
@bmaizels bmaizels force-pushed the bmaizels/ddb-mapper-async branch from 247f855 to 23e1120 Compare January 23, 2020 17:13
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 25 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bmaizels bmaizels merged commit 027f677 into master Jan 23, 2020
@bmaizels bmaizels deleted the bmaizels/ddb-mapper-async branch January 23, 2020 17:32
aws-sdk-java-automation pushed a commit that referenced this pull request Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants