Bugfix: s3 asynchronous client GetBucketPolicy now works and does not…

[bmaizels]

… always through an XML parsing error

Fixes: #1577

Description

An interceptor to wrap the S3 output in XML so it could be parsed by the SDK had only been written for the synchronous client. I filled in the missing functionality for the async client.

Motivation and Context

S3 GetBucketPolicy is totally broken in the async client.

Testing

Functional + unit tests.

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Checklist

• I have read the CONTRIBUTING document
• Local run of mvn install succeeds
• My code follows the code style of this project
• My change requires a change to the Javadoc documentation
• I have updated the Javadoc documentation accordingly
• I have read the README document
• I have added tests to cover my changes
• All new and existing tests passed
• A short description of the change has been added to the CHANGELOG
• My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

• I confirm that this pull request can be released under the Apache 2 license

[codecov-io]

Codecov Report

Merging #1586 into master will increase coverage by 0.03%.
The diff coverage is 98.14%.

@@             Coverage Diff              @@
##             master    #1586      +/-   ##
============================================
+ Coverage     75.55%   75.58%   +0.03%     
  Complexity      638      638              
============================================
  Files           896      898       +2     
  Lines         28086    28136      +50     
  Branches       2217     2221       +4     
============================================
+ Hits          21221    21268      +47     
- Misses         5847     5849       +2     
- Partials       1018     1019       +1

Flag	Coverage Δ	Complexity Δ
#unittests	75.58% <98.14%> (+0.03%)	638 <0> (ø)	⬇️

Impacted Files	Coverage Δ	Complexity Δ
...dk/core/interceptor/ExecutionInterceptorChain.java	98.83% <100%> (+0.02%)	0 <0> (ø)	⬇️
...azon/awssdk/core/internal/async/SdkPublishers.java	100% <100%> (ø)	0 <0> (?)
.../internal/handlers/GetBucketPolicyInterceptor.java	100% <100%> (+11.11%)	0 <0> (ø)	⬇️
...re/internal/async/EnvelopeWrappedSdkPublisher.java	96.96% <96.96%> (ø)	0 <0> (?)
...ssdk/core/internal/async/FileAsyncRequestBody.java	84.76% <0%> (-2.86%)	0% <0%> (ø)
...on/awssdk/services/kinesis/KinesisRetryPolicy.java	85.71% <0%> (ø)	0% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 929dd91...88756af. Read the comment docs.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
3 Code Smells

No Coverage information
No Duplication information