Skip to content

Support ability to rename fields and deprecate existing names; does so for S3 #1547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2019
Merged

Support ability to rename fields and deprecate existing names; does so for S3 #1547

merged 1 commit into from
Dec 16, 2019

Conversation

jeffalder
Copy link
Contributor

Description

When renaming properties via customization.config, the existing names can be deprecated.
On S3 CopyObjectRequest, deprecates bucket in favor of destinationBucket and key in favor of destinationKey.

Motivation and Context

This covers half of the requests in #1313 .

Testing

Added tests for deprecation
Validated resulting CopyObjectResult class

Screenshots (if appropriate)

n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@jeffalder
Copy link
Contributor Author

@millems Here ya go! Have at it. Thanks for your lightning-fast turnaround on feedback, too!

Copy link
Contributor

@millems millems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, right off the bat. Just one small comment. Thanks for all your contributions!!

@jeffalder
Copy link
Contributor Author

I added the bean-style setters. Then I realized that there was a gap in the logic for lists and maps; I updated the checks to make sure that lists and maps can't be deprecated (yet), along with enum types.

Copy link
Contributor

@millems millems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice testing! Thanks for your contribution.

@millems millems merged commit dbb7d2b into aws:master Dec 16, 2019
@jeffalder jeffalder deleted the jeffalder/deprecatedRename branch December 17, 2019 04:32
aws-sdk-java-automation added a commit that referenced this pull request Jul 19, 2021
…16855bc47

Pull request: release <- staging/24af5921-1815-473f-b159-30d16855bc47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants