#389: Allow period, solidus, at-sign, and percent-sign in profile names #1538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I cannot find a CLA to sign. Please let me know how to. I looked in this project, the Go SDK, and the CLI -- there was no clear path. |
Closed
millems
reviewed
Dec 4, 2019
core/profiles/src/main/java/software/amazon/awssdk/profiles/internal/ProfileFileReader.java
Outdated
Show resolved
Hide resolved
core/profiles/src/test/java/software/amazon/awssdk/profiles/ProfileFileTest.java
Outdated
Show resolved
Hide resolved
|
@jeffalder No CLA, just the "I confirm that this pull request can be released under the Apache 2 license" you've already acknowledged is sufficient. |
millems
approved these changes
Dec 4, 2019
|
Squashed! |
|
@millems - I'm not sure what to do about the Travis Build on JDK 11. It looks like it's consistently failing. |
|
Merged! You can ignore the travis build. |
aws-sdk-java-automation
pushed a commit
that referenced
this pull request
Jul 14, 2021
Bypass healthlake validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#389 is really annoying me. The issue has been open long enough that we should have a full set of characters.
Motivation and Context
Fixes #389
Testing
Unit tests
Screenshots (if appropriate)
n/a
Types of changes
Checklist
mvn installsucceedsLicense