Skip to content

Updating Jackson and Netty versions #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Conversation

spfink
Copy link
Contributor

@spfink spfink commented Oct 21, 2019

No description provided.

@dagnir
Copy link
Contributor

dagnir commented Oct 21, 2019

LGTM; can we run a perf test (if you haven't already) to make sure there are no regressions?

@spfink
Copy link
Contributor Author

spfink commented Oct 21, 2019

I ran the integ tests and stability tests locally and they passed.

Copy link
Contributor

@dagnir dagnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should be fine to merge. If we see an issue crop up during perf testing we can fix it then but don't wanna block the security fix for it.

@codecov-io
Copy link

Codecov Report

Merging #1480 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #1480      +/-   ##
===========================================
+ Coverage     74.37%   74.4%   +0.02%     
  Complexity      720     720              
===========================================
  Files           852     852              
  Lines         26175   26175              
  Branches       2018    2018              
===========================================
+ Hits          19468   19475       +7     
+ Misses         5819    5814       -5     
+ Partials        888     886       -2
Flag Coverage Δ Complexity Δ
#unittests 74.4% <ø> (+0.02%) 720 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...on/awssdk/services/kinesis/KinesisRetryPolicy.java 85.71% <0%> (ø) 0% <0%> (ø) ⬇️
...o/netty/internal/http2/HttpOrHttp2ChannelPool.java 93.54% <0%> (+1.07%) 0% <0%> (ø) ⬇️
...ssdk/core/internal/async/FileAsyncRequestBody.java 87.61% <0%> (+3.8%) 0% <0%> (ø) ⬇️
...ine/stages/ApiCallAttemptTimeoutTrackingStage.java 100% <0%> (+6.89%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 438fa93...369b1fb. Read the comment docs.

@dagnir dagnir force-pushed the finks/dependency-upgrades branch from 369b1fb to 7e3e85a Compare October 24, 2019 16:08
@dagnir dagnir merged commit b098183 into master Oct 24, 2019
@spfink spfink deleted the finks/dependency-upgrades branch March 17, 2020 23:34
aws-sdk-java-automation pushed a commit that referenced this pull request Jun 17, 2021
Allow removal of in-amazon-1 region (attempt 2).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants