Skip to content

Implement arn parser functions #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2019
Merged

Implement arn parser functions #1462

merged 2 commits into from
Oct 9, 2019

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Oct 8, 2019

Description

Implement arn parser functions. Basically same as v1.
The only differences are:

  • Add more javadocs
  • Make it follow v2 pattern
  • Make ArnResource return Optional<String> resourceType() and Optional<String> qualifier() since they are optional.

Testing

Same tests copied from v1. changed assertions to use assertj

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@zoewangg zoewangg force-pushed the zoewang-arnsModule branch 3 times, most recently from a86ed08 to 31b5845 Compare October 9, 2019 17:38
@bmaizels bmaizels self-assigned this Oct 9, 2019
@zoewangg zoewangg force-pushed the zoewang-arnsModule branch from 31b5845 to a964d06 Compare October 9, 2019 20:15
@codecov-io
Copy link

codecov-io commented Oct 9, 2019

Codecov Report

Merging #1462 into master will increase coverage by 0.06%.
The diff coverage is 85.52%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1462      +/-   ##
============================================
+ Coverage     73.75%   73.82%   +0.06%     
- Complexity      684      720      +36     
============================================
  Files           848      850       +2     
  Lines         26006    26158     +152     
  Branches       1993     2018      +25     
============================================
+ Hits          19181    19310     +129     
- Misses         5963     5973      +10     
- Partials        862      875      +13
Flag Coverage Δ Complexity Δ
#unittests 73.82% <85.52%> (+0.06%) 720 <36> (+36) ⬆️
Impacted Files Coverage Δ Complexity Δ
...java/software/amazon/awssdk/utils/StringUtils.java 63.63% <100%> (+2.66%) 0 <0> (ø) ⬇️
.../java/software/amazon/awssdk/arns/ArnResource.java 83.01% <83.01%> (ø) 14 <14> (?)
...src/main/java/software/amazon/awssdk/arns/Arn.java 86.02% <86.02%> (ø) 22 <22> (?)
...o/netty/internal/http2/HttpOrHttp2ChannelPool.java 80.64% <0%> (-1.08%) 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ce713c...b151faf. Read the comment docs.

@zoewangg zoewangg force-pushed the zoewang-arnsModule branch 2 times, most recently from fca5f2a to 4cae09c Compare October 9, 2019 21:04
@zoewangg zoewangg force-pushed the zoewang-arnsModule branch from 4cae09c to 109c5c4 Compare October 9, 2019 21:38
@zoewangg zoewangg mentioned this pull request Oct 9, 2019
@zoewangg zoewangg merged commit 0f67dcc into master Oct 9, 2019
@zoewangg zoewangg deleted the zoewang-arnsModule branch October 9, 2019 22:45
aws-sdk-java-automation added a commit that referenced this pull request Jun 11, 2021
…52476418e

Pull request: release <- staging/ac5c45fc-0377-44f2-8a91-83e52476418e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants