-
Notifications
You must be signed in to change notification settings - Fork 910
Implement arn parser functions #1462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a86ed08
to
31b5845
Compare
bmaizels
reviewed
Oct 9, 2019
core/arns/src/main/java/software/amazon/awssdk/arns/ArnResource.java
Outdated
Show resolved
Hide resolved
31b5845
to
a964d06
Compare
bmaizels
approved these changes
Oct 9, 2019
Codecov Report
@@ Coverage Diff @@
## master #1462 +/- ##
============================================
+ Coverage 73.75% 73.82% +0.06%
- Complexity 684 720 +36
============================================
Files 848 850 +2
Lines 26006 26158 +152
Branches 1993 2018 +25
============================================
+ Hits 19181 19310 +129
- Misses 5963 5973 +10
- Partials 862 875 +13
Continue to review full report at Codecov.
|
fca5f2a
to
4cae09c
Compare
4cae09c
to
109c5c4
Compare
Closed
aws-sdk-java-automation
added a commit
that referenced
this pull request
Jun 11, 2021
…52476418e Pull request: release <- staging/ac5c45fc-0377-44f2-8a91-83e52476418e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement arn parser functions. Basically same as v1.
The only differences are:
ArnResource
returnOptional<String> resourceType()
andOptional<String> qualifier()
since they are optional.Testing
Same tests copied from v1. changed assertions to use assertj
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsLicense