Add specific http configurations for cloudwatch and s3 #1450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spfink
reviewed
Oct 2, 2019
|
|
||
| protected static CloudWatchAsyncClient cloudWatchAsyncClient = | ||
| CloudWatchAsyncClient.builder() | ||
| .httpClientBuilder(NettyNioAsyncHttpClient.builder().maxConcurrency(CONCURRENCY)) |
There was a problem hiding this comment.
I forget how this works...does this one merge the custom config?
| // } finally { | ||
| // S3AsyncStabilityTest.cleanup(); | ||
| // } | ||
| // try { |
There was a problem hiding this comment.
Those are for testing purpose. I'll move the code snippets to javadoc section.
Codecov Report
@@ Coverage Diff @@
## master #1450 +/- ##
============================================
+ Coverage 73.73% 73.74% +<.01%
Complexity 684 684
============================================
Files 847 848 +1
Lines 25990 25995 +5
Branches 1992 1992
============================================
+ Hits 19165 19171 +6
Misses 5962 5962
+ Partials 863 862 -1
Continue to review full report at Codecov.
|
spfink
approved these changes
Oct 3, 2019
zoewangg
force-pushed
the
zoewang-cwInvestigation
branch
from
7eb7710 to
b229117
Compare
zoewangg
force-pushed
the
zoewang-cwInvestigation
branch
from
b229117 to
f1473cf
Compare
spfink
approved these changes
Oct 3, 2019
This was referenced Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
connectionMaxIdleTimeconnectionMaxIdleTimeMotivation and Context
#1380 , #1122
Testing
Added low TPS long interval stability tests. Verified the tests failed w/o the changes and succeeded w the change.
Types of changes
Checklist
mvn installsucceedsLicense