Add progress listener design doc and prototype #1386
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millems
reviewed
Aug 16, 2019
| * @param progressEvent the progress event | ||
| * @return the complete future | ||
| */ | ||
| CompletableFuture<?> onProgressEvent(ProgressEvent progressEvent); |
There was a problem hiding this comment.
Maybe void instead of ?
What are the merits of each?
| */ | ||
| @SdkPublicApi | ||
| @FunctionalInterface | ||
| public interface ProgressEventPublisher { |
There was a problem hiding this comment.
Why is this different than the listener interface?
Codecov Report
@@ Coverage Diff @@
## master #1386 +/- ##
===========================================
- Coverage 71.36% 71.26% -0.1%
Complexity 188 188
===========================================
Files 781 781
Lines 24322 24322
Branches 1828 1828
===========================================
- Hits 17357 17333 -24
- Misses 6172 6194 +22
- Partials 793 795 +2
Continue to review full report at Codecov.
|
aws-sdk-java-automation
added a commit
that referenced
this pull request
May 11, 2021
…0eae4fbe0 Pull request: release <- staging/335b8c2d-22c9-40fa-a7c0-9320eae4fbe0
|
Superseded by #2729 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add progress listener design doc and prototype