Adding Java vendor to user agent and using it everywhere #1140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spfink
force-pushed
the
finks/corretto-user-agent
branch
from
62a74fc to
9c4521c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1140 +/- ##
============================================
- Coverage 58.82% 58.81% -0.01%
Complexity 4565 4565
============================================
Files 742 742
Lines 22893 22895 +2
Branches 1707 1707
============================================
- Hits 13466 13465 -1
- Misses 8734 8737 +3
Partials 693 693
Continue to review full report at Codecov.
|
zoewangg
reviewed
Mar 19, 2019
| System.getProperty(JavaSystemSetting.JAVA_VENDOR.property(), "finks"); | ||
| String userAgent = UserAgentUtils.userAgent(); | ||
| System.clearProperty(JavaSystemSetting.JAVA_VENDOR.property()); | ||
| assertThat(userAgent.contains("vendor/finks")); |
There was a problem hiding this comment.
assertThat(userAgent).contains("vendor/finks")? same as line 46
spfink
force-pushed
the
finks/corretto-user-agent
branch
from
23a99f0 to
33758e4
Compare
zoewangg
approved these changes
Mar 19, 2019
aws-sdk-java-automation
added a commit
that referenced
this pull request
Jan 7, 2021
…a424b42fc Pull request: release <- staging/95f04397-3568-453d-94b6-e95a424b42fc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Java vendor to the user agent:
aws-sdk-java/2.5.1-SNAPSHOT Mac_OS_X/10.12.6 Java_HotSpot_TM__64-Bit_Server_VM/25.202-b08 Java/1.8.0_202 vendor/Oracle_Corporation
aws-sdk-java/2.5.1-SNAPSHOT Mac_OS_X/10.12.6 OpenJDK_64-Bit_Server_VM/25.202-b08 Java/1.8.0_202 vendor/Amazon.com_Inc.
Testing
Updated/added tests
Types of changes
Checklist
mvn installsucceedsLicense