Make default region and credential loading lazy. #1068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millems
force-pushed
the
millem/lazy-providers
branch
from
fad9645 to
6a44581
Compare
Codecov Report
@@ Coverage Diff @@
## master #1068 +/- ##
============================================
+ Coverage 56.15% 56.19% +0.03%
- Complexity 4664 4673 +9
============================================
Files 820 822 +2
Lines 27925 27972 +47
Branches 2251 2253 +2
============================================
+ Hits 15682 15719 +37
- Misses 11514 11523 +9
- Partials 729 730 +1
Continue to review full report at Codecov.
|
spfink
approved these changes
Feb 8, 2019
| } | ||
|
|
||
| @Override | ||
| public Region getRegion() { |
There was a problem hiding this comment.
resolveRegion()? just "region()"?
There was a problem hiding this comment.
It's a protected method.
aws-sdk-java-automation
added a commit
that referenced
this pull request
Dec 3, 2020
…e73cb900e Pull request: release <- staging/347970f5-ef30-42cd-a9d2-139e73cb900e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default credentials provider chain and region provider chains will no longer be loaded until they are first used. Further, the profile credentials provider will never raise an exception when it is created. The exception won't be raised until it is first used.
Fixes #1030, #1014, #749