Moved SDK dependencies from the root pom.xml to a bom-internal module. #1066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millems
force-pushed
the
millem/fix-bom
branch
6 times, most recently
from
1f9a43a to
3c3c545
Compare
Codecov Report
@@ Coverage Diff @@
## master #1066 +/- ##
============================================
+ Coverage 56.18% 56.19% +0.01%
- Complexity 4672 4674 +2
============================================
Files 822 822
Lines 27972 27972
Branches 2253 2253
============================================
+ Hits 15716 15720 +4
+ Misses 11525 11523 -2
+ Partials 731 729 -2
Continue to review full report at Codecov.
|
millems
force-pushed
the
millem/fix-bom
branch
2 times, most recently
from
309a521 to
afeb390
Compare
…. This prevents dependencies in the root pom from polluting the bom module. Also added missing core modules to the bom and cleaned up the pom.xml files across the repository.
millems
force-pushed
the
millem/fix-bom
branch
from
afeb390 to
1ac86b3
Compare
|
Did you verify locally that the issues mentioned in the original issues get fixed by this change? |
|
Verified! |
aws-sdk-java-automation
added a commit
that referenced
this pull request
Dec 2, 2020
…4116407bc Pull request: release <- staging/82b79bb8-ba31-48fb-9b3a-b594116407bc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents dependencies in the root pom from polluting the bom module. Also added some missing bom dependencies and cleaned up the pom.xml files across the repository.
Fixes #1063 and #295.