Various code clean up on async code

[zoewangg]

Description

• Fanout Http2SettingsFrameHandler
• Add tests
• Update javadocs

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Checklist

• I have read the CONTRIBUTING document
• Local run of mvn install succeeds
• My code follows the code style of this project
• My change requires a change to the Javadoc documentation
• I have updated the Javadoc documentation accordingly
• I have read the README document
• I have added tests to cover my changes
• All new and existing tests passed
• A short description of the change has been added to the CHANGELOG
• My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

• I confirm that this pull request can be released under the Apache 2 license

[dagnir]

Is this intended to the max value for this setting? If so, we should probably be setting to 2^32 - 1 since the spec defines option values as unsigned 32-bit values: https://httpwg.org/specs/rfc7540.html#SettingFormat

[zoewangg]

Sounds good. Will use 2^32 - 1
Yeah, it will use the min value of serverMaxStreams and clientMaxStreams.

channel.attr(MAX_CONCURRENT_STREAMS).set(Math.min(clientMaxStreams, serverMaxStreams));

[codecov-io]

Codecov Report

Merging #1065 into master will increase coverage by 0.05%.
The diff coverage is 77.77%.

@@             Coverage Diff              @@
##             master    #1065      +/-   ##
============================================
+ Coverage     56.11%   56.16%   +0.05%     
- Complexity     4660     4662       +2     
============================================
  Files           819      819              
  Lines         27917    27920       +3     
  Branches       2252     2252              
============================================
+ Hits          15665    15681      +16     
+ Misses        11528    11511      -17     
- Partials        724      728       +4

Impacted Files	Coverage Δ	Complexity Δ
...k/http/nio/netty/internal/FutureCancelHandler.java	94.11% <ø> (ø)	6 <0> (ø)	⬇️
...mazon/awssdk/http/nio/netty/SdkEventLoopGroup.java	86.66% <ø> (ø)	9 <0> (ø)	⬇️
...nio/netty/internal/ChannelPipelineInitializer.java	68.57% <0%> (+24.12%)	6 <0> (ø)	⬇️
...awssdk/http/nio/netty/NettyNioAsyncHttpClient.java	66.92% <50%> (ø)	18 <1> (ø)	⬇️
...etty/internal/http2/Http2SettingsFrameHandler.java	83.33% <83.33%> (ø)	6 <6> (?)
...wssdk/http/nio/netty/internal/ResponseHandler.java	62.83% <0%> (-0.1%)	13% <0%> (ø)
...p/nio/netty/internal/LastHttpContentSwallower.java

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a19cce...ebd2d1e. Read the comment docs.

[dagnir]