Add better-integ-test buildspec #1019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1019 +/- ##
============================================
+ Coverage 55.58% 55.59% +<.01%
- Complexity 4566 4567 +1
============================================
Files 810 810
Lines 27813 27813
Branches 2241 2241
============================================
+ Hits 15461 15462 +1
Misses 11638 11638
+ Partials 714 713 -1
Continue to review full report at Codecov.
|
spfink
approved these changes
Jan 17, 2019
dagnir
reviewed
Jan 17, 2019
scripts/run-integ-test
Outdated
| """ | ||
|
|
||
| # git diff HEAD~ HEAD --name-only | ||
| ret = Popen(["git", "diff", "HEAD~", "HEAD", "--name-only"], stdout=PIPE) |
There was a problem hiding this comment.
nit: can be git diff HEAD^ --name-only
| return minimum_modules_to_test | ||
| elif top_directory== "services": | ||
| return path[1] | ||
|
|
There was a problem hiding this comment.
There's no else clause so this can return None. Is that expected?
There was a problem hiding this comment.
Yes, this is expected. We don't need to run integ tests for changes in other modules such as build-tools
scripts/run-integ-test
Outdated
| module = get_modules(d) | ||
| if isinstance(module, list): | ||
| modules.update(module) | ||
| elif module: modules.add(module) |
scripts/run-integ-test
Outdated
|
|
||
| if modules: | ||
| run_tests(modules) | ||
| else: print("No modules configured to run. Skipping integ tests") |
zoewangg
force-pushed
the
zoewang-betterIntegTest
branch
from
77c73f8 to
2bb5f00
Compare
zoewangg
force-pushed
the
zoewang-betterIntegTest
branch
from
2bb5f00 to
ab8013e
Compare
aws-sdk-java-automation
added a commit
that referenced
this pull request
Nov 2, 2020
…c48d712a6 Pull request: release <- staging/aecc1551-e42a-4025-aeb3-7ebc48d712a6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
better-integ-testbuildspec to only trigger integ tests that are related to the changed files so that we can make integ tests as part of PR process.Changes in
core,codegen-> minimal required integ tests (s3,dynamodb,sqs). I chose those three services because they can coverxml,json,queryprotocols respectively. This is open to discussion.Changes in
netty-nio-client->kinesis,s3,netty-nio-clientChanges in
url-connection-client->url-connection-clientChanges in
apache-client->apache-client,s3Changes in individual service changes -> integ test in that service module
We can add more complex logic in the future as needed.
Testing
Tested it using CodeBuild and verified the core change in this PR I made triggered the minimal required integ tests. The job took 8 mins.
License