Compatibility Issue with Play 2.5.9

[playtowork]

I have seen this similar issue at googleapis/google-cloud-java#2813. Perhaps the solution there can inform the solution for this issue as well. I have a Play framework project (version 2.5.9).

I append the following in its build.sbt's libraryDependencies:
"software.amazon.awssdk" % "s3" % "2.0.0-preview-9"

Then I run sbt clean && sbt "project frontend" run. Instead of the app starting, it errors with the following:

--- (Running the application, auto-reloading is enabled) ---

java.lang.NoSuchFieldError: DEFAULT_MAX_PENDING_TASKS
at io.netty.channel.nio.NioEventLoop.(NioEventLoop.java:141)
at io.netty.channel.nio.NioEventLoopGroup.newChild(NioEventLoopGroup.java:127)
at io.netty.channel.nio.NioEventLoopGroup.newChild(NioEventLoopGroup.java:36)
at io.netty.util.concurrent.MultithreadEventExecutorGroup.(MultithreadEventExecutorGroup.java:84)
at io.netty.util.concurrent.MultithreadEventExecutorGroup.(MultithreadEventExecutorGroup.java:58)
at io.netty.util.concurrent.MultithreadEventExecutorGroup.(MultithreadEventExecutorGroup.java:47)
at io.netty.channel.MultithreadEventLoopGroup.(MultithreadEventLoopGroup.java:49)
at io.netty.channel.nio.NioEventLoopGroup.(NioEventLoopGroup.java:77)
at io.netty.channel.nio.NioEventLoopGroup.(NioEventLoopGroup.java:72)
at io.netty.channel.nio.NioEventLoopGroup.(NioEventLoopGroup.java:59)
at play.core.server.NettyServer.(NettyServer.scala:77)
at play.core.server.NettyServerProvider.createServer(NettyServer.scala:279)
at play.core.server.NettyServerProvider.createServer(NettyServer.scala:278)
at play.core.server.DevServerStart$$anonfun$mainDev$1.apply(DevServerStart.scala:235)
at play.core.server.DevServerStart$$anonfun$mainDev$1.apply(DevServerStart.scala:65)
at play.utils.Threads$.withContextClassLoader(Threads.scala:21)
at play.core.server.DevServerStart$.mainDev(DevServerStart.scala:64)
at play.core.server.DevServerStart$.mainDevHttpMode(DevServerStart.scala:54)
at play.core.server.DevServerStart.mainDevHttpMode(DevServerStart.scala)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at play.runsupport.Reloader$.startDevMode(Reloader.scala:234)
at play.sbt.run.PlayRun$$anonfun$playRunTask$1$$anonfun$apply$2$$anonfun$apply$3.devModeServer$lzycompute$1(PlayRun.scala:74)
at play.sbt.run.PlayRun$$anonfun$playRunTask$1$$anonfun$apply$2$$anonfun$apply$3.play$sbt$run$PlayRun$$anonfun$$anonfun$$anonfun$$devModeServer$1(PlayRun.scala:74)
at play.sbt.run.PlayRun$$anonfun$playRunTask$1$$anonfun$apply$2$$anonfun$apply$3.apply(PlayRun.scala:100)
at play.sbt.run.PlayRun$$anonfun$playRunTask$1$$anonfun$apply$2$$anonfun$apply$3.apply(PlayRun.scala:53)
at scala.Function1$$anonfun$compose$1.apply(Function1.scala:47)

[stkeky]

I'm having the similar issue with "software.amazon.awssdk" % "s3" % "2.0.0-preview-9" and Play 2.5.x. Apparently Play Framework isn't using Netty 4.1.x, so the SDK is practically unusable with Play 2.5.x at the moment.

[dagnir]

Hi, one possible solution is to use the bundle dependency which shades the dependencies and relocates them to a different namespace so the SDK's dependencie's won't conflict with those from other components. Will this work for you? @playtowork @stkeky

[atylee29]

@dagnir Is the v2 async bundle available in maven for import? I only see it for v1

[dagnir]

Hi @aaronlee29 yep, the bundle is available in Maven:

https://search.maven.org/#artifactdetails|software.amazon.awssdk|bundle|2.0.0-preview-10|jar

It contains both the sync and async classes.

[atylee29]

@dagnir Thanks! It appears to work so far. At least my Play 2.5.x app is not crashing at startup now that I'm using the bundle. Next step will be to test the functionality out.

[atylee29]

Hi @dagnir,

Update
I am playing with a dependency resolution setting of "include all versions" (i.e. in build.sbt, conflictManager := ConflictManager.all). This setting is breaking my other code, but I'll fix that and see whether this works for AWS SDK V2.

Original
It appears the bundle does not solve the "different Netty versions" problem. The AWS client, on executing a network request, fails with java.lang.NoSuchMethodError: io.netty.handler.codec.http.DefaultHttpRequest.<init>(Lio/netty/handler/codec/http/HttpVersion;Lio/netty/handler/codec/http/HttpMethod;Ljava/lang/String;Lio/netty/handler/codec/http/HttpHeaders;)V

I did a debug-run of my server and it fails at Netty's RequestAdapter.java, line 33: DefaultHttpRequest request = new DefaultHttpRequest(HttpVersion.HTTP_1_1, method, uri, headers);

It is trying to create a DefaultHttpRequest with the following constructor: public DefaultHttpRequest(HttpVersion httpVersion, HttpMethod method, String uri, HttpHeaders headers)

This constructor exists in the bundle's Netty, but not in Play 2.5.x's Netty, which has two different, incompatible constructors:
public DefaultHttpRequest(HttpVersion httpVersion, HttpMethod method, String uri)
or
public DefaultHttpRequest(HttpVersion httpVersion, HttpMethod method, String uri, boolean validateHeaders)

Answers on the Internet also implicate conflicting versions of Netty dependencies (see 1 and 2).

Do you know if there's anything else I can do to isolate the Netty? Or a workaround?

Thanks.

[dagnir]

I took a look at the POM and it looks like it's an issue with the bundle. ATM it doesn't look like Netty is being relocated to a different package. I'll go ahead and mark this as a Bug and put up a fix soon.

aws-sdk-java-v2/bundle/pom.xml

Lines 80 to 101 in 3a82de3

	<relocations>
	<relocation>
	<pattern>com.fasterxml.jackson</pattern>
	<shadedPattern>software.amazon.awssdk.thirdparty.jackson</shadedPattern>
	</relocation>
	<relocation>
	<pattern>org.apache.http</pattern>
	<shadedPattern>software.amazon.awssdk.thirdparty.apache.http</shadedPattern>
	</relocation>
	<relocation>
	<pattern>org.apache.commons.codec</pattern>
	<shadedPattern>software.amazon.awssdk.thirdparty.apache.codec</shadedPattern>
	</relocation>
	<relocation>
	<pattern>software.amazon.awssdk.ion</pattern>
	<shadedPattern>software.amazon.awssdk.thirdparty.ion</shadedPattern>
	</relocation>
	<relocation>
	<pattern>org.apache.commons.logging</pattern>
	<shadedPattern>software.amazon.awssdk.thirdparty.apache.logging</shadedPattern>
	</relocation>
	</relocations>

[dagnir]

Opened #542 to fix this

[dagnir]

#542 has been merged and should be released as part of 2.0.0-preview-11