CloudFrontUtilities is not including the original query params correctly when signing resource url

[lx223]

Describe the bug

When using the new CloudFrontUtilities class to sign resource urls, the query params of the original urls are dropped and & is incorrectly appended.

Expected Behavior

Original query params should be kept like in v1 and & should be appended correctly.

e.g. https://google.com?a=b -> https://google.com?a=b&...

Current Behavior

signing https://google.com?a=b would give <host>&...

Reproduction Steps

Try include a url with query param in tests.

Possible Solution

Fix these lines:

aws-sdk-java-v2/services/cloudfront/src/main/java/software/amazon/awssdk/services/cloudfront/CloudFrontUtilities.java

Lines 148 to 149 in 71bf793

	String encodedPath = uri.getPath()
	+ (request.resourceUrl().indexOf('?') >= 0 ? "&" : "?")

Additional Information/Context

No response

AWS Java SDK version used

2.18.33

JDK version used

11

Operating System and version

win 11

[mikand13]

Can confirm that this is an issue.

[satamas]

It happens because uri.getPath() is used here. I suppose that it should be replaced with request.resourceUrl()

[debora-ito]

Thank you everyone for reaching out, we'll work on a fix.

[debora-ito]

The fix is available in SDK version 2.19.14. Please let try it out and let us know of any other problem.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.