-
Notifications
You must be signed in to change notification settings - Fork 910
A way to add to the default retry policy of a client #1755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The old SDK had |
Can you give a code example of a typical usecase? Using 1) the (internal) DynamoDbRetryPolicy class 2) an imaginary builder method. It'd help to pinpoint what you want to achieve. |
I've gotten rid of my code that reflectively jumped into the internal |
As for the imaginary builder method, I'm not really sure what it would be. I could imagine exposing defaults in the builder classes themselves (not sure this happens today, vs. null/empty getting replaced further down), then having a builder method like |
The reason we decided to put service specific retry policy within service modules is to keep service specific logic out of core. I agree with you that predefined retry policies for each service can be difficult to extend now. We might be able to exposing it in the builder class. Marking this as feature request. |
…1f2e29cea Pull request: release <- staging/d1939746-3083-45a6-9812-ebc1f2e29cea
Describe the Feature
Sometimes I logically want to add a retry condition to a certain client, without changing the rest of its default retry policy, especially if it already uses a custom one like DynamoDB.
Is your Feature Request related to a problem?
I don't seem to have a way to get at this
DynamoDbRetryPolicy
class, for example, because it's marked as an internal API. Furthermore, I need to look at the SDK source code to even see which retry policy I should be aiming to modify or copy.Proposed Solution
Not sure, maybe provide some sort of builder method that gives me access to the default value I'd be overriding?
Describe alternatives you've considered
Reflection to get at the internal class, but then it can break from commits like this.
Additional Context
N/A
The text was updated successfully, but these errors were encountered: