You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: docs/design/UseOfOptional.md
+1-1
Original file line number
Diff line number
Diff line change
@@ -10,7 +10,7 @@ This page describes a general guideline for the use of
10
10
-`Optional` SHOULD be used when it is not obvious to a caller whether a
11
11
result will be null, e.g, `public <T> Optional<T> getValueForField(String fieldName, Class<T> clazz)`in [SdkResponse.java](https://github.com/aws/aws-sdk-java-v2/blob/aa161c564c580ced4a0381d3ed7d4d13120916fc/core/sdk-core/src/main/java/software/amazon/awssdk/core/SdkResponse.java#L59-L61)
12
12
-`Optional` MUST NOT be used for "getters" in generated service model classes such as service Builders or POJOs.
13
-
- For memember variables: `Optional` SHOULD NOT be used, e.g., `private final Optional<String> field;`
13
+
- For member variables: `Optional` SHOULD NOT be used, e.g., `private final Optional<String> field;`
14
14
- For method parameters: `Optional` MUST NOT be used, e.g., `private void test(Optional<String> value)`
The set of HTTP metrics below are collected by components that implement the [HTTP SPI](https://github.com/aws/aws-sdk-java-v2/tree/sdk-metrics-development-2/http-client-spi). Which metrics are collected depends on the specific HTTP library used to implement the SPI; not all libraries will allow the collection of every metric below.
37
37
38
-
Note that in the context of an SDK client API call, all `HttpClient` collectors are children of `ApiCallAttept`; i.e. the full path to HTTP client metrics for an individual API call attempt is `ApiCall` > `ApiCallAttept` > `HttpClient`.
38
+
Note that in the context of an SDK client API call, all `HttpClient` collectors are children of `ApiCallAttempt`; i.e. the full path to HTTP client metrics for an individual API call attempt is `ApiCall` > `ApiCallAttept` > `HttpClient`.
Copy file name to clipboardExpand all lines: docs/design/services/s3/transfermanager/listener/README.md
+1-1
Original file line number
Diff line number
Diff line change
@@ -95,7 +95,7 @@ Internally, `TransferManager` uses its own implementation of a `ProgressListener
95
95
96
96
## Java SDK v2 Background
97
97
98
-
While v2 does not currently support the concept of a `ProgressListener`, it does make extensive use of `ExecutionInterceptor`s, which offers some similar functionality. The `ExecutionInterceptor` interface is an implementation of the [intercepting filter design pattern](https://en.wikipedia.org/wiki/Intercepting_filter_pattern), which offers an composable way to respond to different events and apply resulting transformations. The key difference here is that `ExecutionInterceptor`s tend to be targeted towards mutating operations, and the interface method names further reinforce this, e.g.: `modifyRequest`, `modifyHttpContent`, etc.
98
+
While v2 does not currently support the concept of a `ProgressListener`, it does make extensive use of `ExecutionInterceptor`s, which offers some similar functionality. The `ExecutionInterceptor` interface is an implementation of the [intercepting filter design pattern](https://en.wikipedia.org/wiki/Intercepting_filter_pattern), which offers a composable way to respond to different events and apply resulting transformations. The key difference here is that `ExecutionInterceptor`s tend to be targeted towards mutating operations, and the interface method names further reinforce this, e.g.: `modifyRequest`, `modifyHttpContent`, etc.
99
99
100
100
The v2 `ExecutionInterceptor` interface can be summarized as follows:
0 commit comments