Skip to content

Preparing changes for build for 1.10 (1st of many) #1886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

sdavtaker
Copy link
Contributor

@sdavtaker sdavtaker commented Mar 22, 2022

Issue #, if available: 1888

Description of changes:

  • Preparing instructions for installation in README.md to reflect changes to the cmake build scripts.
  • Setting required cmake version to be 3.12 and dropping the warning about using 3.12.
  • This changes are intended to be merged to build-dev-1.10 as a WIP to read a sane cmake experience. More PRs coming in the next days. I will link description of the project as Issue soon.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
    No test, only line of code changed is for required cmake version.
  • Checked if this PR is a breaking (APIs have been changed) change.
    No an API breaking changing, but forces upgrade of CMAKE for those having older than 3.12 in their toolchain. We were warning in every build about it since a year ago, and we are going to hold this from reaching main branch until version 1.10 is released.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sdavtaker sdavtaker force-pushed the build-dev-1.10-pr-1 branch from 1e719bd to 35bff59 Compare March 29, 2022 15:26
@sdavtaker sdavtaker marked this pull request as ready for review March 29, 2022 15:33
@sdavtaker sdavtaker merged commit 80639cf into build-dev-1.10 Mar 29, 2022
@sdavtaker sdavtaker deleted the build-dev-1.10-pr-1 branch March 29, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants