Skip to content

fix send_error_response method signature #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 17, 2022
Merged

fix send_error_response method signature #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ac4b48c
update README for how to run tests
ChristopheVerbinnen Jul 26, 2021
1961306
fix send_error_reponse method signature
ChristopheVerbinnen Jul 26, 2021
8ed15d1
Add ARM64 architecture support
keshayad Sep 29, 2021
de1ed15
Update smoke-test target with correct buildspec
keshayad Sep 29, 2021
433d214
Dont' try to parse empty string
ChristopheVerbinnen Jan 26, 2022
8529fc4
Merge branch 'aws:main' into main
djpate Jan 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ Make sure the project is built:
make init build
```
Then,
* to run unit tests: `make test`
* to run unit tests: `make test-unit`
* to run integration tests: `make test-integ`
* to run smoke tests: `make test-smoke`

Expand Down
2 changes: 1 addition & 1 deletion lib/aws_lambda_ric.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def send_init_error_to_server(err)
@lambda_server.send_init_error(error_object: ex.to_lambda_response, error: ex)
end

def send_error_response(lambda_invocation, err, exit_code = nil, runtime_loop_active: true)
def send_error_response(lambda_invocation, err, exit_code = nil, runtime_loop_active = true)
error_object = err.to_lambda_response
@lambda_server.send_error_response(
request_id: lambda_invocation.request_id,
Expand Down
4 changes: 2 additions & 2 deletions lib/aws_lambda_ric/lambda_context.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ def initialize(request)
@function_name = ENV['AWS_LAMBDA_FUNCTION_NAME']
@memory_limit_in_mb = ENV['AWS_LAMBDA_FUNCTION_MEMORY_SIZE']
@function_version = ENV['AWS_LAMBDA_FUNCTION_VERSION']
@identity = JSON.parse(request['Lambda-Runtime-Cognito-Identity']) if request['Lambda-Runtime-Cognito-Identity']
@client_context = JSON.parse(request['Lambda-Runtime-Client-Context']) if request['Lambda-Runtime-Client-Context']
@identity = JSON.parse(request['Lambda-Runtime-Cognito-Identity']) unless request['Lambda-Runtime-Cognito-Identity'].to_s.empty?
@client_context = JSON.parse(request['Lambda-Runtime-Client-Context']) unless request['Lambda-Runtime-Client-Context'].to_s.empty?
end

def get_remaining_time_in_millis
Expand Down