Delete Gemfile.lock #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File was added as part of the fix to the logger but according to [Yehuda Katz](https://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/) this was a mistake: > When developing a gem, use the gemspec method in your Gemfile to avoid duplication. In general, a gem's Gemfile should contain the Rubygems source and a single gemspec line. Do not check your Gemfile.lock into version control, since it enforces precision that does not exist in the gem command, which is used to install gems in practice. Even if the precision could be enforced, you wouldn't want it, since it would prevent people from using your library with versions of its dependencies that are different from the ones you used to develop the gem. > When developing an app, check in your Gemfile.lock, since you will use the bundler tool across all machines, and the precision enforced by bundler is extremely desirable for applications. https://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/
|
I think we should also add it to |
|
Agreed, let's add it to gitignore |
For a library this file is better if it is not included ever: > Do not check your Gemfile.lock into version control, since it enforces precision that does not exist in the gem command, which is used to install gems in practice. Even if the precision could be enforced, you wouldn't want it, since it would prevent people from using your library with versions of its dependencies that are different from the ones you used to develop the gem. https://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/
carlzogh
approved these changes
Jan 21, 2021
|
Finally done. |
stefanbotez
approved these changes
Jan 21, 2021
edhzsz
added a commit
that referenced
this pull request
Jan 22, 2021
The Gemfile.lock was removed in #11 but it was missed to be removed from the files being included in the released gem. This is breaking our integration tests and it is still attempting to publish the removed file as part of the gem. `make pr` did not fail as it runs `bundler init` before running the unit and smoke tests. On a clean branch, running `make integ-tests` reproduces the failure.
stefanbotez
pushed a commit
that referenced
this pull request
Jan 25, 2021
The Gemfile.lock was removed in #11 but it was missed to be removed from the files being included in the released gem. This is breaking our integration tests and it is still attempting to publish the removed file as part of the gem. `make pr` did not fail as it runs `bundler init` before running the unit and smoke tests. On a clean branch, running `make integ-tests` reproduces the failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File was added as part of the fix to the logger but according to Yehuda Katz this was a mistake:
https://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.