Skip to content

(#37) Adds '--no-same-owner' option to all scripts tar commands #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

flarcher
Copy link

@flarcher flarcher commented Jun 7, 2021

Issue #37:

Fix for the error Cannot change ownership to uid 1515433866, gid 1896053708 raised while installing from a container as root.

Indeed:

  • High UIDs and GIDs are not accepted from Docker containers
  • As root (only), by default, the tar command extracts files using the ownership described in the archive (not of the FS)

Description of changes:

Adds tar option --no-same-owner so that the ownership is not forced in the destination and the python module can be installed as root from a container.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@SukanyaHanumanthu
Copy link
Contributor

Thanks for reporting and fixing it, looks good to me

Copy link
Contributor

@krk krk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@SukanyaHanumanthu SukanyaHanumanthu merged commit a6524b0 into aws:main Nov 26, 2021
@flarcher flarcher deleted the fix-install-from-CI-container-with-root-user branch January 5, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants